qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: JonY <10walls@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Windows build broken
Date: Thu, 13 Dec 2007 08:47:02 +0800	[thread overview]
Message-ID: <47608106.6030300@gmail.com> (raw)
In-Reply-To: <47604A79.1010804@mail.berlios.de>

Stefan Weil wrote:
> basetyps.h is included by windows.h / rpc.h. QEMU does not need it, so
> you can avoid it like this:
> 
> #define WIN32_LEAN_AND_MEAN
> #include <windows.h>
> 
> WIN32_LEAN_AND_MEAN reduces the number of includes in windows.h
> and increases compilation speed. And you don't have to rename
> variables like interface :-)
> 
> Regards,
> Stefan
> 
> Eduardo Felipe schrieb:
>> 2007/12/12, C.W. Betts <computers57@hotmail.com
>> <mailto:computers57@hotmail.com>>:
>>
>>     Could you perhaps give a patch?  I don't feel like going through
>>     and changing every instance of BlockInterfaceType to something else.
>>
>>
>> Having a closer look I think the underlying problem is a name conflict
>> with a #define in Mingw's header file basetyps.h, so renaming
>> variables looks right to me. Patch attached.
>>
>> Regards,
>>
>>

Hi,

I would prefer Eduardo's patch, defining WIN32_LEAN_AND_MEAN breaks dsound.

Thanks.

  reply	other threads:[~2007-12-13  0:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-12  3:05 [Qemu-devel] Windows build broken Balazs Attila-Mihaly (Cd-MaN)
2007-12-12 10:08 ` C.W. Betts
2007-12-12 10:41   ` Eduardo Felipe
2007-12-12 15:27     ` C.W. Betts
2007-12-12 19:50       ` Eduardo Felipe
2007-12-12 20:54         ` Stefan Weil
2007-12-13  0:47           ` JonY [this message]
2007-12-13 20:20             ` [Qemu-devel][Patch] " Stefan Weil
2007-12-14  1:39               ` JonY
2007-12-14 19:05                 ` Stefan Weil
2007-12-16 13:54                   ` Paul Brook
  -- strict thread matches above, loose matches on Subject: below --
2005-07-12  6:05 [Qemu-devel] ^[$B!y!z0lK|1_J,%W%l%<%s%H!z!y^[(B info
2005-07-12 16:20 ` [Qemu-devel] Windows build broken Andreas Bollhalder
2005-07-13 20:14   ` Andreas Bollhalder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47608106.6030300@gmail.com \
    --to=10walls@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).