From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J2cEP-0004oP-09
	for qemu-devel@nongnu.org; Wed, 12 Dec 2007 19:47:17 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1J2cEL-0004kc-Ae
	for qemu-devel@nongnu.org; Wed, 12 Dec 2007 19:47:16 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J2cEL-0004kW-8T
	for qemu-devel@nongnu.org; Wed, 12 Dec 2007 19:47:13 -0500
Received: from rv-out-0910.google.com ([209.85.198.188])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <10walls@gmail.com>) id 1J2cEL-0003af-A1
	for qemu-devel@nongnu.org; Wed, 12 Dec 2007 19:47:13 -0500
Received: by rv-out-0910.google.com with SMTP id g11so1547948rvb.22
	for <qemu-devel@nongnu.org>; Wed, 12 Dec 2007 16:47:09 -0800 (PST)
Message-ID: <47608106.6030300@gmail.com>
Date: Thu, 13 Dec 2007 08:47:02 +0800
From: JonY <10walls@gmail.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Windows build broken
References: <802848.87427.qm@web57002.mail.re3.yahoo.com>	<BAY133-DAV521037E9AFD28300472F2B9650@phx.gbl>	<83a4d4ca0712120241n77b602a3v22990b2bb12ca4e2@mail.gmail.com>	<BAY133-DAV9167896565967A2A160BDB9650@phx.gbl>	<83a4d4ca0712121150q6b7ec678yb64eb7a5f2dbb363@mail.gmail.com>
	<47604A79.1010804@mail.berlios.de>
In-Reply-To: <47604A79.1010804@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Stefan Weil wrote:
> basetyps.h is included by windows.h / rpc.h. QEMU does not need it, so
> you can avoid it like this:
> 
> #define WIN32_LEAN_AND_MEAN
> #include <windows.h>
> 
> WIN32_LEAN_AND_MEAN reduces the number of includes in windows.h
> and increases compilation speed. And you don't have to rename
> variables like interface :-)
> 
> Regards,
> Stefan
> 
> Eduardo Felipe schrieb:
>> 2007/12/12, C.W. Betts <computers57@hotmail.com
>> <mailto:computers57@hotmail.com>>:
>>
>>     Could you perhaps give a patch?  I don't feel like going through
>>     and changing every instance of BlockInterfaceType to something else.
>>
>>
>> Having a closer look I think the underlying problem is a name conflict
>> with a #define in Mingw's header file basetyps.h, so renaming
>> variables looks right to me. Patch attached.
>>
>> Regards,
>>
>>

Hi,

I would prefer Eduardo's patch, defining WIN32_LEAN_AND_MEAN breaks dsound.

Thanks.