From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J2e7J-0002u1-KS for qemu-devel@nongnu.org; Wed, 12 Dec 2007 21:48:05 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J2e7I-0002to-4C for qemu-devel@nongnu.org; Wed, 12 Dec 2007 21:48:04 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2e7H-0002tl-V8 for qemu-devel@nongnu.org; Wed, 12 Dec 2007 21:48:03 -0500 Received: from gateway-1237.mvista.com ([63.81.120.158]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J2e7H-0003Uq-K7 for qemu-devel@nongnu.org; Wed, 12 Dec 2007 21:48:03 -0500 Received: from pahoa.hi.kama-aina.net (unknown [10.235.20.2]) by hermes.mvista.com (Postfix) with ESMTP id 3AC6E1F178 for ; Wed, 12 Dec 2007 18:48:00 -0800 (PST) Message-ID: <47609D5F.20107@kama-aina.net> Date: Wed, 12 Dec 2007 16:47:59 -1000 From: Armin MIME-Version: 1.0 Subject: Re: [Qemu-devel] [Patch 1/2][PXA27x] initial keypad support References: <475F3D80.3080102@kama-aina.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org andrzej zaborowski wrote: > Hi, > > On 12/12/2007, Armin wrote: > >> Here is an attempt to add PXA27x keypad support. It currently only >> supports the matrix type interface. It still needs direct and >> mulitswitch support added. >> >> Just wanted to get something out there for folks to pound on. >> >> Comment and feedback welcome. >> > > Here are some comments: > > * Several bits in KPC and KPREC should be reset on read. The IRQ > should be reset when it becomes masked in KPC, and potentially > asserted when it becomes unmasked. > Done, I think I got the reset on read . The MI and DI interrupt bits are set after a scan has completed and then the IRQ is asserted. I think I got it. > * It's wasteful to go through all keys in the 8x8 matrix on every > event. It can be avoided easily by mapping qemu keycode to matrix > position, rather than position to keycode, for example the PalmT|E > matrix keypad does that. > Yeah, that was a bit overkill ; ) > * Please convert the indentation in the file to use spaces, before > considering for inclusion. > > sure thing > * The bit definitions and pxa2xx_keypad_s struct are local to the > keypad module so they shouldn't be in the header file exposed to the > whole world. > Ok. > * Please set a copyright owner. > Ok. > Regarding mainstone keypad patch: > > * Probably not worth to stick the keymap in a file of its own since it > is not shared between different machines - it's an integral part of > mainstone. > Done Thanks for the feedback. New patches to follow. -Armin