From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J4Ozh-0005WM-Md for qemu-devel@nongnu.org; Mon, 17 Dec 2007 18:03:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J4Ozf-0005VK-C6 for qemu-devel@nongnu.org; Mon, 17 Dec 2007 18:03:28 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J4Ozf-0005VH-9v for qemu-devel@nongnu.org; Mon, 17 Dec 2007 18:03:27 -0500 Received: from neuf-infra-smtp-out-sp604007av.neufgp.fr ([84.96.92.120]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J4Oze-0005s0-Ku for qemu-devel@nongnu.org; Mon, 17 Dec 2007 18:03:26 -0500 Message-ID: <47670010.6090409@bellard.org> Date: Tue, 18 Dec 2007 00:02:40 +0100 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/2 v2][UPDATED] Direct IDE I/O References: <11979293592467@bull.net> In-Reply-To: <11979293592467@bull.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Laurent Vivier wrote: > This patch enhances the "-drive ,cache=off" mode with IDE drive emulation > by removing the buffer used in the IDE emulation. > --- > block.c | 10 +++ > block.h | 2 > block_int.h | 1 > cpu-all.h | 1 > exec.c | 19 ++++++ > hw/ide.c | 176 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- > vl.c | 1 > 7 files changed, 204 insertions(+), 6 deletions(-) > [...] Unfortunately it is more complicated to write to the CPU memory. In particular, specific action should be done when translated code is present. A consistent API must include something like cpu_page_lock() / unlock(). Look at cpu_physical_memory_rw() to see the various issues which must be handled. Moreover, it would be better to add bus specific APIs (at least for PCI), but I can accept a CPU memory API for now. Fabrice.