From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J4P5w-0006oT-4M
	for qemu-devel@nongnu.org; Mon, 17 Dec 2007 18:09:56 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1J4P5u-0006nn-TK
	for qemu-devel@nongnu.org; Mon, 17 Dec 2007 18:09:55 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J4P5u-0006nk-Qq
	for qemu-devel@nongnu.org; Mon, 17 Dec 2007 18:09:54 -0500
Received: from neuf-infra-smtp-out-sp604006av.neufgp.fr ([84.96.92.121])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fabrice@bellard.org>) id 1J4P5u-0007DL-89
	for qemu-devel@nongnu.org; Mon, 17 Dec 2007 18:09:54 -0500
Message-ID: <47670182.6070908@bellard.org>
Date: Tue, 18 Dec 2007 00:08:50 +0100
From: Fabrice Bellard <fabrice@bellard.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2 v2][UPDATE] Add "cache" parameter to
	"-drive"
References: <11979293583970@bull.net>
In-Reply-To: <11979293583970@bull.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <Laurent.Vivier@bull.net>, qemu-devel@nongnu.org

Laurent Vivier wrote:
> This patch adds a new parameter to "-drive"
> 
> Using "cache=off" with "-drive" will open the disk image file using
> "O_DIRECT".
> 
> By default, "cache" is set to "on" to keep original behavior of qemu.
> 
> example:
> 
> "-drive file=my_disk.qcow2,cache=off"
> ---
>  block-raw-posix.c |    8 ++++++++
>  block-raw-win32.c |    4 ++++
>  block.c           |    2 +-
>  block.h           |    1 +
>  hw/fdc.c          |    7 ++++++-
>  hw/ide.c          |   18 ++++++++++++++----
>  hw/scsi-disk.c    |    3 ++-
>  hw/sd.c           |   11 ++++++++++-
>  osdep.c           |   20 ++++++++++++++++++++
>  osdep.h           |    1 +
>  vl.c              |   28 ++++++++++++++++++++++++----
>  11 files changed, 91 insertions(+), 12 deletions(-)
> [...]

I suggest trying to remove the malloc/free which are done at every
blk_read/write for sd.c.

Fabrice.