From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J4c2o-0001qH-9p for qemu-devel@nongnu.org; Tue, 18 Dec 2007 07:59:34 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J4c2i-0001k1-Kr for qemu-devel@nongnu.org; Tue, 18 Dec 2007 07:59:33 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J4c2i-0001jl-G9 for qemu-devel@nongnu.org; Tue, 18 Dec 2007 07:59:28 -0500 Received: from mtagate3.uk.ibm.com ([195.212.29.136]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J4c2i-00064P-4N for qemu-devel@nongnu.org; Tue, 18 Dec 2007 07:59:28 -0500 Received: from d06nrmr1407.portsmouth.uk.ibm.com (d06nrmr1407.portsmouth.uk.ibm.com [9.149.38.185]) by mtagate3.uk.ibm.com (8.13.8/8.13.8) with ESMTP id lBICxLDu162952 for ; Tue, 18 Dec 2007 12:59:21 GMT Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id lBICxL3u4886532 for ; Tue, 18 Dec 2007 12:59:21 GMT Received: from d06av03.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lBICx5bm016520 for ; Tue, 18 Dec 2007 12:59:05 GMT Message-ID: <4767C408.6060008@linux.vnet.ibm.com> Date: Tue, 18 Dec 2007 13:58:48 +0100 From: Christian Ehrhardt MIME-Version: 1.0 References: <11975745782686-git-send-email-ehrhardt@linux.vnet.ibm.com> <42DFA526FC41B1429CE7279EF83C6BDCAD01E3@pdsmsx415.ccr.corp.intel.com> <476247EB.9040003@linux.vnet.ibm.com> <1197943018.5026.0.camel@diesel> In-Reply-To: <1197943018.5026.0.camel@diesel> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [kvm-devel] [PATCH][UPDATE] kvm-userspace: sync icache for morearchitectures Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hollis Blanchard Cc: kvm-devel@lists.sourceforge.net, kvm-ppc-devel@lists.sourceforge.net, qemu-devel@nongnu.org Hollis Blanchard wrote: > On Fri, 2007-12-14 at 10:07 +0100, Christian Ehrhardt wrote: >> Hollis Blanchard wrote: >>> A comment to explain why the icache needs flushing only in the KVM >> case >>> would be useful. Other than that I'm fine with it. >>> >>> Signed-off-by: Hollis Blanchard >> AFAIK Plain qemu does not directly execute guest code on the >> processor, >> so the icache is not an issue for it. >> Qemu itself has the flush_icache_range function only as helper for the >> dynamic code generation. >> But we may now write executable guest code with our intercepted mmio >> handling that is directly executed when switching back to the guest >> context, therefore we need that invalidation in the kvm case. >> >> For the case that I'm overlooking something in plain qemu, so that it >> might need it too I add qemu-devel@nongnu.org for comments from there, >> but currently I think to have it in #ifdef USE_KVM is the right way. >> >> >> P.S. Hollis did you mean you would like to see a comment in the code >> where that call takes place? >=20 > Yes! Hopefully much shorter than this email... :-P >=20 comment added, rebased and resent together with a updated mmio callback simplification patch - I hope I didn't overlook a response to the mmio callback thread again this time ;-) --=20 Gr=FCsse / regards,=20 Christian Ehrhardt IBM Linux Technology Center, Open Virtualization +49 7031/16-3385 Ehrhardt@linux.vnet.ibm.com Ehrhardt@de.ibm.com IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Johann Weihen=20 Gesch=E4ftsf=FChrung: Herbert Kircher=20 Sitz der Gesellschaft: B=F6blingen Registergericht: Amtsgericht Stuttgart, HRB 243294