[PATCH] Re: [Qemu-devel] QEMU keyboard issue with Gujin-2.2

[PATCH] Re: [Qemu-devel] QEMU keyboard issue with Gujin-2.2

[Etienne Lorrain]

  Hello,

 I have digged further my problem of keyboard problem when the mouse is activated
using qemu (i.e. dummy char present in the keyboard buffer), and can say that
this patch solves completely the problem:
--------------------
$ diff -urp qemu-0.9.0-init qemu-0.9.0
diff -urp qemu-0.9.0-init/hw/pckbd.c qemu-0.9.0/hw/pckbd.c
--- qemu-0.9.0-init/hw/pckbd.c  2007-02-05 23:01:54.000000000 +0000
+++ qemu-0.9.0/hw/pckbd.c       2007-10-16 20:32:40.000000000 +0100
@@ -202,7 +202,7 @@ static void kbd_write_command(void *opaq
 #endif
     switch(val) {
     case KBD_CCMD_READ_MODE:
-        kbd_queue(s, s->mode, 0);
+        kbd_queue(s, s->mode, 1);
         break;
     case KBD_CCMD_WRITE_MODE:
     case KBD_CCMD_WRITE_OBUF:
--------------------
 To reproduce my problem, just download "gujin install pack" install-2.2.tar.gz
from http://gujin.sf.net , then extract boot.144 to run qemu like:
i386-softmmu/qemu -fda boot.144 -L ~/qemu-0.9.0/pc-bios/
You should be able to see the problem immediately, and see it fixed with the patch.
The problem seems to be that a keyboard IRQ is generated by this command, and
it is later converted to a "key typed" by re-reading the data port, when interrupts
are re-enabled. I am not a specialist of rombios.c of bochs (but I did not need
to modify it), but Gujin is just using the BIOS mouse interface - not touching 
I/O ports 0x60 and 0x64 (except enable A20).

 I hope this patch will be included in the next release.
 Thanks for the qemu software,

 Etienne.

--
 "Knowledge is not enough, we must apply." (Bruce Lee)



      _____________________________________________________________________________ 
Ne gardez plus qu'une seule adresse mail ! Copiez vos mails vers Yahoo! Mail 

Re: [PATCH] Re: [Qemu-devel] QEMU keyboard issue with Gujin-2.2

[Avi Kivity]

Etienne Lorrain wrote:
>   Hello,
>
>  I have digged further my problem of keyboard problem when the mouse is activated
> using qemu (i.e. dummy char present in the keyboard buffer), and can say that
> this patch solves completely the problem:
> --------------------
> $ diff -urp qemu-0.9.0-init qemu-0.9.0
> diff -urp qemu-0.9.0-init/hw/pckbd.c qemu-0.9.0/hw/pckbd.c
> --- qemu-0.9.0-init/hw/pckbd.c  2007-02-05 23:01:54.000000000 +0000
> +++ qemu-0.9.0/hw/pckbd.c       2007-10-16 20:32:40.000000000 +0100
> @@ -202,7 +202,7 @@ static void kbd_write_command(void *opaq
>  #endif
>      switch(val) {
>      case KBD_CCMD_READ_MODE:
> -        kbd_queue(s, s->mode, 0);
> +        kbd_queue(s, s->mode, 1);
>          break;
>      case KBD_CCMD_WRITE_MODE:
>      case KBD_CCMD_WRITE_OBUF:
>   

This patch (which is present in qemu-cvs) kills the mouse in suse linux 9.1.

-- 
error compiling committee.c: too many arguments to function