From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE9DC4361B for ; Wed, 16 Dec 2020 15:29:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 203FB233EA for ; Wed, 16 Dec 2020 15:29:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 203FB233EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpYkV-0000f1-Rf for qemu-devel@archiver.kernel.org; Wed, 16 Dec 2020 10:29:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpYgo-0006kz-35 for qemu-devel@nongnu.org; Wed, 16 Dec 2020 10:26:06 -0500 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]:35205) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpYgj-00077P-Kp for qemu-devel@nongnu.org; Wed, 16 Dec 2020 10:26:05 -0500 Received: by mail-oi1-x22d.google.com with SMTP id s2so27881613oij.2 for ; Wed, 16 Dec 2020 07:26:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EBiJLFbCoGaT5KSrVznC/DIBoyJXIdpSOQsDldGdams=; b=ifATdx7nqBMKPo2KSvxlghEjymbVFPmMgdYzAp8m/wEoPf9L3Vq+E+4OsaO6SQo0Qq I9E05FUk/pZnm7LsYaYhHU/GiMcDCTLyaYLGJN/jS9UHIfTM1phDoWeli/561C554qNM +r4NvgNF+w6KLxHNEALi0vevV/P4RnlAGCVJmxG7KxOrex5RNHX20F5dZrjrOPkQxHC9 vMNZP2b5Q4Wu1pJAcSNdYWjG643njSeXmcOem5Ld7aOLq9ImwmiKFOWinsQtV2mkU97z fpEUuFIO68U05C0q5pGrH69TcTee7vdxiA8jzwL5LQ4o9OYvuoc4tvqO2lT4P7NYWHJp UVsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EBiJLFbCoGaT5KSrVznC/DIBoyJXIdpSOQsDldGdams=; b=ofvMDuLn6e3SLVDL30FXWBMKj6bTlWEOZTZRkr+EoJWNOfK9XxPiqX42nXL0vJ91qy uKaNZxBz2NHA1EGnrS5W854EX+HDJAbDKT7RqKTkf8r2WAuCOarumcny5UZblALg1MHW hIsSmWWNhyf5z+pE2ia2+Gd8nltFMzuQU5oispZu+B/k/5VepdtiNFjHF5EzdVuitoq9 tc7HsVcDJn/AGC00+awd3C6F36yynQ+WsDrsN6YfPwF0bgPHKaQ+Jl5GSFu1cN9C/4c4 UgYgrvhv190rbkAVTpL6ZKvGuSBzGtHYS2zQg7Oksm4JqixraFzeN5E9xR1ZAzYGf2SG e5KA== X-Gm-Message-State: AOAM532Yq4Ump9HzArRN1PU1uPEN12b4jrk6KpEGIIh/AFErZ5kvzkif k4UOOvEse2VGVLarfULqx1oxWg== X-Google-Smtp-Source: ABdhPJwHG4/HaDrPKlDLJX8nrwNX3DFGmb7GRvHfDZUJHhzWJYYxjG279ov5WlRfkIt0JyeDBdyIjw== X-Received: by 2002:aca:ec13:: with SMTP id k19mr2310751oih.97.1608132360448; Wed, 16 Dec 2020 07:26:00 -0800 (PST) Received: from [10.10.121.52] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id s23sm598074oot.0.2020.12.16.07.25.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Dec 2020 07:25:59 -0800 (PST) Subject: Re: [PATCH 3/3] trace: do not include TCG helper tracepoints in no-TCG builds To: Paolo Bonzini , qemu-devel@nongnu.org References: <20201216135529.265165-1-pbonzini@redhat.com> <20201216135529.265165-4-pbonzini@redhat.com> <98e787e4-884b-61c5-bf52-b041f57747c3@linaro.org> From: Richard Henderson Message-ID: <476adc2f-fbff-48a9-78fa-ce64cc3e5f80@linaro.org> Date: Wed, 16 Dec 2020 09:25:57 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::22d; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x22d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/16/20 9:22 AM, Paolo Bonzini wrote: > On 16/12/20 16:13, Richard Henderson wrote: >>> @@ -71,7 +71,7 @@ foreach d : [ >>>                   input: meson.project_source_root() / 'trace-events', >>>                   command: [ tracetool, '--group=root', >>> '--format=@0@'.format(d[1]), '@INPUT@' ], >>>                   capture: true) >>> -  specific_ss.add(gen) >>> +  specific_ss.add(when: 'CONFIG_TCG', if_true: gen) >>>   endforeach >> >> Sure, unless it makes more sense to conditionalize the entire loop, so that >> those targets aren't even created? > > The targets exist but the files won't be created (the rules will be in > build.ninja but they'll be orphan). Yes, I get that. So... is there a reason for them to be there, when it seems just as easy for them not to be? r~