From: Harsh Prateek Bora <harshpb@linux.ibm.com>
To: Daniel Henrique Barboza <danielhb413@gmail.com>, qemu-ppc@nongnu.org
Cc: qemu-devel@nongnu.org, farosas@suse.de, npiggin@gmail.com
Subject: Re: [PATCH v3 1/2] ppc: spapr: cleanup cr get/set with helpers.
Date: Thu, 4 May 2023 11:03:51 +0530 [thread overview]
Message-ID: <476da90d-02e3-1e22-61eb-05724412e75b@linux.ibm.com> (raw)
In-Reply-To: <6dc41ce7-264f-db9f-b15a-6d83907fc925@gmail.com>
On 5/4/23 02:19, Daniel Henrique Barboza wrote:
> I squashed in this change to fix it:
>
>
> diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c
> index 241d9e27e5..424f2e1741 100644
> --- a/target/ppc/cpu.c
> +++ b/target/ppc/cpu.c
> @@ -75,7 +75,7 @@ void ppc_set_cr(CPUPPCState *env, uint64_t cr)
> }
> }
> -uint64_t ppc_get_cr(CPUPPCState *env)
> +uint64_t ppc_get_cr(const CPUPPCState *env)
> {
> uint64_t cr = 0;
> for (int i = 0; i < 8; i++) {
> diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
> index 0af94170d0..1c02596d9f 100644
> --- a/target/ppc/cpu.h
> +++ b/target/ppc/cpu.h
> @@ -2774,7 +2774,7 @@ void ppc_maybe_bswap_register(CPUPPCState *env,
> uint8_t *mem_buf, int len);
> void ppc_store_vscr(CPUPPCState *env, uint32_t vscr);
> uint32_t ppc_get_vscr(CPUPPCState *env);
> void ppc_set_cr(CPUPPCState *env, uint64_t cr);
> -uint64_t ppc_get_cr(CPUPPCState *env);
> +uint64_t ppc_get_cr(const CPUPPCState *env);
>
> /*****************************************************************************/
>
>
> Just a FYI,. No need to re-send.
>
Oh ok, thanks Daniel.
>
>
> Daniel
next prev parent reply other threads:[~2023-05-04 5:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 9:36 [PATCH v3 0/2] Cleanup ppc cr get/set with helper routines Harsh Prateek Bora
2023-05-03 9:36 ` [PATCH v3 1/2] ppc: spapr: cleanup cr get/set with helpers Harsh Prateek Bora
2023-05-03 10:09 ` Richard Henderson
2023-05-03 20:49 ` Daniel Henrique Barboza
2023-05-04 5:33 ` Harsh Prateek Bora [this message]
2023-05-03 9:36 ` [PATCH v3 2/2] MAINTAINERS: Adding myself in the list for ppc/spapr Harsh Prateek Bora
2023-05-03 14:31 ` [PATCH v3 0/2] Cleanup ppc cr get/set with helper routines Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476da90d-02e3-1e22-61eb-05724412e75b@linux.ibm.com \
--to=harshpb@linux.ibm.com \
--cc=danielhb413@gmail.com \
--cc=farosas@suse.de \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).