From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>, qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] audio: use TYPE_MV88W8618_AUDIO instead of hardcoded string
Date: Fri, 12 Oct 2018 11:53:45 +0200 [thread overview]
Message-ID: <477885af-51fc-56a0-0ff0-0ce67d3fa123@redhat.com> (raw)
In-Reply-To: <20181012083008.29027-4-maozhongyi@cmss.chinamobile.com>
On 12/10/2018 10:30, Mao Zhongyi wrote:
> Cc: Jan Kiszka <jan.kiszka@web.de>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> To: qemu-arm@nongnu.org
>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/arm/musicpal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
> index ac266f9253..9648b3af44 100644
> --- a/hw/arm/musicpal.c
> +++ b/hw/arm/musicpal.c
> @@ -1693,7 +1693,7 @@ static void musicpal_init(MachineState *machine)
> }
>
> wm8750_dev = i2c_create_slave(i2c, TYPE_WM8750, MP_WM_ADDR);
> - dev = qdev_create(NULL, "mv88w8618_audio");
> + dev = qdev_create(NULL, TYPE_MV88W8618_AUDIO);
> s = SYS_BUS_DEVICE(dev);
> object_property_set_link(OBJECT(dev), OBJECT(wm8750_dev),
> TYPE_WM8750, NULL);
>
next prev parent reply other threads:[~2018-10-12 9:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 8:30 [Qemu-devel] [PATCH v2 0/3] use object link instead of qdev property Mao Zhongyi
2018-10-12 8:30 ` [Qemu-devel] [PATCH v2 1/3] audio: use TYPE_WM8750 instead of a hardcoded string Mao Zhongyi
2018-10-12 9:50 ` Philippe Mathieu-Daudé
2018-10-12 10:14 ` [Qemu-devel] [PATCH v2 1/3] audio: use TYPE_WM8750 instead of ahardcoded string maozy
2018-10-12 8:30 ` [Qemu-devel] [PATCH v2 2/3] audio: use object link instead of qdev property to pass wm8750 reference Mao Zhongyi
2018-10-12 9:53 ` Philippe Mathieu-Daudé
2018-10-12 11:51 ` [Qemu-devel] [PATCH v2 2/3] audio: use object link instead ofqdev " maozy
2018-10-12 12:30 ` Philippe Mathieu-Daudé
2018-10-12 18:40 ` Philippe Mathieu-Daudé
2018-10-15 2:14 ` [Qemu-devel] [PATCH v2 2/3] audio: use object link instead ofqdevproperty " maozy
2018-10-12 8:30 ` [Qemu-devel] [PATCH v2 3/3] audio: use TYPE_MV88W8618_AUDIO instead of hardcoded string Mao Zhongyi
2018-10-12 9:53 ` Philippe Mathieu-Daudé [this message]
2018-10-12 9:58 ` maozy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477885af-51fc-56a0-0ff0-0ce67d3fa123@redhat.com \
--to=philmd@redhat.com \
--cc=jan.kiszka@web.de \
--cc=maozhongyi@cmss.chinamobile.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).