From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J9ots-00042x-PV
	for qemu-devel@nongnu.org; Tue, 01 Jan 2008 16:43:52 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1J9otq-0003xm-IY
	for qemu-devel@nongnu.org; Tue, 01 Jan 2008 16:43:51 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J9otq-0003xP-C1
	for qemu-devel@nongnu.org; Tue, 01 Jan 2008 16:43:50 -0500
Received: from neuf-infra-smtp-out-sp604006av.neufgp.fr ([84.96.92.121])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fabrice@bellard.org>) id 1J9otp-000812-RY
	for qemu-devel@nongnu.org; Tue, 01 Jan 2008 16:43:50 -0500
Message-ID: <477AB3D4.5080106@bellard.org>
Date: Tue, 01 Jan 2008 22:42:44 +0100
From: Fabrice Bellard <fabrice@bellard.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] qemu cpu-all.h exec.c
References: <E1J9kQZ-0006Tj-Gh@cvs.savannah.gnu.org>
In-Reply-To: <E1J9kQZ-0006Tj-Gh@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Blue Swirl wrote:
> CVSROOT:	/cvsroot/qemu
> Module name:	qemu
> Changes by:	Blue Swirl <blueswir1>	08/01/01 16:57:19
> 
> Modified files:
> 	.              : cpu-all.h exec.c 
> 
> Log message:
> 	 Support for registering address space only for some access widths
> 
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/cpu-all.h?cvsroot=qemu&r1=1.80&r2=1.81
> http://cvs.savannah.gnu.org/viewcvs/qemu/exec.c?cvsroot=qemu&r1=1.120&r2=1.121

This patch breaks the behaviour of the memory callbacks if the callbacks
are changed dynamically (see cirrus_update_memory_access() to see what I
mean). You are lucky that no one does that in the subpage case !

Regards,

Fabrice.