From: "Andre Przywara" <andre.przywara@amd.com>
To: ehrhardt@linux.vnet.ibm.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [kvm-ppc-devel] The default for char Literals differ in signedness between platforms causing us a lot of warnings
Date: Wed, 16 Jan 2008 13:59:48 +0100 [thread overview]
Message-ID: <478DFFC4.7030903@amd.com> (raw)
In-Reply-To: <478DF8B3.1080909@linux.vnet.ibm.com>
Christian,
> Newer gcc versions generate warnings about implicit casts between
> different signed pointers.
> That hits a lot of qemu code at least what I saw it compiling for ppc
> or x86.
> So my question is, is there already a preferred qemu approach to get
> rid of these warnings
> either the -Wno-pointer-sign solution like in the kernel or something
> else (I did not find
> anything like that in the latest cvs snapshot or on this list)?
I fixed some of these issues in qemu at least for x86[1][2], those were
commited mid of December[3] . I ported these over to Xen and posted it
there[4]. I don't know what's the ultimate policy regarding these
problems, my solution is:
1. Change the type whenever possible.
2. Introduce casts if 1. is not applicable or would introduce more
back-castings.
Regards,
Andre.
[1] QEMU first proposal (all in one file) with comments:
http://lists.gnu.org/archive/html/qemu-devel/2007-11/msg00827.html
[2] QEMU reworked version (splitted up to address multiple issues)
http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00146.html
[3] QEMU commits:
http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00417.html
http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00420.html
http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00448.html
http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00452.html
[4] Xen devel post
http://lists.xensource.com/archives/html/xen-devel/2008-01/msg00185.html
--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 277-84917
----to satisfy European Law for business letters:
AMD Saxony Limited Liability Company & Co. KG,
Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Register Court Dresden: HRA 4896, General Partner authorized
to represent: AMD Saxony LLC (Wilmington, Delaware, US)
General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
prev parent reply other threads:[~2008-01-16 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <47876B99.1000600@linux.vnet.ibm.com>
[not found] ` <1200063861.5833.19.camel@basalt>
[not found] ` <F18E75E0-C457-4A24-96E4-BB4F72F03C2F@pobox.com>
2008-01-16 12:29 ` [Qemu-devel] Re: [kvm-ppc-devel] The default for char Literals differ in signedness between platforms causing us a lot of warnings Christian Ehrhardt
2008-01-16 12:59 ` Andre Przywara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478DFFC4.7030903@amd.com \
--to=andre.przywara@amd.com \
--cc=ehrhardt@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).