From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JFBAU-00033P-5P
	for qemu-devel@nongnu.org; Wed, 16 Jan 2008 11:31:10 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JFBAR-00030m-93
	for qemu-devel@nongnu.org; Wed, 16 Jan 2008 11:31:09 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JFBAR-00030c-31
	for qemu-devel@nongnu.org; Wed, 16 Jan 2008 11:31:07 -0500
Received: from an-out-0708.google.com ([209.85.132.248])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1JFBAR-0000QT-8B
	for qemu-devel@nongnu.org; Wed, 16 Jan 2008 11:31:07 -0500
Received: by an-out-0708.google.com with SMTP id b38so94862ana.130
	for <qemu-devel@nongnu.org>; Wed, 16 Jan 2008 08:31:06 -0800 (PST)
Message-ID: <478E3150.2000904@codemonkey.ws>
Date: Wed, 16 Jan 2008 10:31:12 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] add VNC reverse connections
References: <478DB1D3.60905@cs.ucla.edu> <20080116124231.GB16624@redhat.com>
	<478E1E0F.1040303@cs.ucla.edu>
In-Reply-To: <478E1E0F.1040303@cs.ucla.edu>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Eddie Kohler wrote:
> Daniel P. Berrange wrote:
>> We already have the ability to pass multiple flags / options to the VNC
>> driver as a post-fix to the host:port pair, so I'm not a fan of 
>> introducing
>> a new option as a prefix. If using existing options syntax, it could 
>> look
>> like:
>>
>>   -vnc :5500,rev
>>   -vnc read.cs.ucla.edu:5500,rev
>
> This doesn't feel like an option to me, though; rather a different 
> means of connecting.  Among other things, in "-vnc :0", the QEMU VNC 
> server opens port 5900.  But the client's listening port for reverse 
> connections defaults to 5500.  "-vnc :-400,rev" is clearly insane, but 
> it seems strange for an option like ",rev" to change the meaning of 
> the port field.
>
> If you still disagree I'll produce a patch with ",reverse" as an option.

I'm not a huge fan of the "option,mod,mod" syntax but Dan is right, it's 
what is used in QEMU.  Consistency is often times better than sanity :-)

Regards,

Anthony Liguori

> Eddie
>
>