From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JFT11-0004VB-CN
	for qemu-devel@nongnu.org; Thu, 17 Jan 2008 06:34:35 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JFT0u-0004OU-2K
	for qemu-devel@nongnu.org; Thu, 17 Jan 2008 06:34:32 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JFT0t-0004Ns-L9
	for qemu-devel@nongnu.org; Thu, 17 Jan 2008 06:34:27 -0500
Received: from kassel160.server4you.de ([62.75.246.160] helo=csgraf.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <alex@csgraf.de>) id 1JFT0t-0001Wn-AR
	for qemu-devel@nongnu.org; Thu, 17 Jan 2008 06:34:27 -0500
Received: from [10.10.100.38] (charybdis-ext.suse.de [195.135.221.2])
	by csgraf.de (Postfix) with ESMTP id 81156615F
	for <qemu-devel@nongnu.org>; Thu, 17 Jan 2008 12:34:25 +0100 (CET)
Message-ID: <478F09B8.5060404@csgraf.de>
Date: Thu, 17 Jan 2008 08:54:32 +0100
From: Alexander Graf <alex@csgraf.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/5] Fix i386 Host
References: <478EF8DE.2050103@csgraf.de>
	<alpine.LSU.1.00.0801171119070.17650@racer.site>
In-Reply-To: <alpine.LSU.1.00.0801171119070.17650@racer.site>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Johannes Schindelin wrote:
> Hi,
>
> On Thu, 17 Jan 2008, Alexander Graf wrote:
>
>   
>> This patch is mostly a cleanup of Michael Matz's patch with the ideas 
>> that came last time included.
>>     
>
> Maybe the patch subject could be "prepare i386 host for gcc4, step 1)?
>
>   

Basically it fixes it, just not completely ;-).

>> Index: qemu/softmmu_header.h
>> ===================================================================
>> --- qemu.orig/softmmu_header.h
>> +++ qemu/softmmu_header.h
>> @@ -189,9 +189,11 @@ static inline void glue(glue(st, SUFFIX)
>>  #else
>>  #error unsupported size
>>  #endif
>> +                  "pushl %%ecx\n"
>>                    "pushl %6\n"
>>                    "call %7\n"
>>                    "popl %%eax\n"
>> +                  "popl %%ecx\n"
>>     
>
> Could you guard this so that this code is only included for gcc4?  (I am 
> assuming that it is not needed for gcc3, as it worked so far...)
>
>   
You're right on that one. Thanks for the catch.