From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JFVis-0004G7-FD
	for qemu-devel@nongnu.org; Thu, 17 Jan 2008 09:28:02 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JFViq-0004Fb-4H
	for qemu-devel@nongnu.org; Thu, 17 Jan 2008 09:28:02 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JFVip-0004FY-So
	for qemu-devel@nongnu.org; Thu, 17 Jan 2008 09:27:59 -0500
Received: from kassel160.server4you.de ([62.75.246.160] helo=csgraf.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <alex@csgraf.de>) id 1JFVip-0003oT-B5
	for qemu-devel@nongnu.org; Thu, 17 Jan 2008 09:27:59 -0500
Received: from [10.10.100.38] (charybdis-ext.suse.de [195.135.221.2])
	by csgraf.de (Postfix) with ESMTP id 164F86152
	for <qemu-devel@nongnu.org>; Thu, 17 Jan 2008 15:27:58 +0100 (CET)
Message-ID: <478F65ED.6090500@csgraf.de>
Date: Thu, 17 Jan 2008 15:27:57 +0100
From: Alexander Graf <alex@csgraf.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/5] Fix i386 Host
References: <478EF8DE.2050103@csgraf.de>	<alpine.LSU.1.00.0801171119070.17650@racer.site>	<478F09B8.5060404@csgraf.de>
	<alpine.LSU.1.00.0801171310100.17650@racer.site>
In-Reply-To: <alpine.LSU.1.00.0801171310100.17650@racer.site>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Johannes Schindelin wrote:
> Hi,
>
> I get an error with sh4-linux-user and sh4eb-linux-user:
>
> ../dyngen -o op.h op.o
> dyngen: ret or jmp expected at the end of op_cmp_str_T0_T1
>
>   

Yes, and it's mostly right about this. This specific opcode ends with a
jmp, which dyngen does not allow. I leave this to the SH4 developers, as
they know way better what this opcode is supposed to do.

> There is a "RETURN();" statement at the end of 
> target-sh4/op.c:op_cmp_str_T0_T1() though, so I am puzzled...
>   

It simply doesn't help ;-).

> It also says "target-ppc/exec.h:44:26: error: #if with no expression", 
> because there is an "#if GCC_BREAKS_T_REGISTER" which wants to be an 
> "#ifdef".  (This is in patch 1/5.)
>
>   

Fixed. Thank you.