From: David Hildenbrand <david@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, qemu-devel@nongnu.org
Cc: thuth@redhat.com, pmorel@linux.ibm.com, cohuck@redhat.com,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
mihajlov@linux.ibm.com
Subject: Re: [PATCH 2/4] s390x: Cleanup cpu resets
Date: Fri, 22 Nov 2019 12:14:10 +0100 [thread overview]
Message-ID: <4793f8ae-a709-2a41-ea71-4197a026b58a@redhat.com> (raw)
In-Reply-To: <20191122075218.23935-3-frankja@linux.ibm.com>
[...]
>
> #if !defined(CONFIG_USER_ONLY)
> @@ -473,9 +459,9 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data)
> #if !defined(CONFIG_USER_ONLY)
> scc->load_normal = s390_cpu_load_normal;
> #endif
> - scc->cpu_reset = s390_cpu_reset;
> - scc->initial_cpu_reset = s390_cpu_initial_reset;
> - cc->reset = s390_cpu_full_reset;
> + scc->cpu_reset = s390_cpu_reset_normal;
> + scc->initial_cpu_reset = s390_cpu_reset_initial;
What about having only one function here
scc->cpu_reset(), where you directly pass in the reset type
instead of scc->cpu_reset/scc->initial_cpu_reset?
> + cc->reset = s390_cpu_reset_clear;
> cc->class_by_name = s390_cpu_class_by_name,
> cc->has_work = s390_cpu_has_work;
> #ifdef CONFIG_TCG
>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-11-22 11:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 7:52 [PATCH 0/4] s390x: Reset cleanup Janosch Frank
2019-11-22 7:52 ` [PATCH 1/4] s390x: Don't do a normal reset on the initial cpu Janosch Frank
2019-11-22 10:55 ` David Hildenbrand
2019-11-22 7:52 ` [PATCH 2/4] s390x: Cleanup cpu resets Janosch Frank
2019-11-22 10:35 ` Philippe Mathieu-Daudé
2019-11-22 13:07 ` Janosch Frank
2019-11-22 11:14 ` David Hildenbrand [this message]
2019-11-22 12:20 ` [PATCH] Remove wrappers Janosch Frank
2019-11-22 12:23 ` David Hildenbrand
2019-11-22 12:28 ` Janosch Frank
2019-11-22 7:52 ` [PATCH 3/4] s390x: Beautify diag308 handling Janosch Frank
2019-11-22 10:56 ` David Hildenbrand
2019-11-22 7:52 ` [PATCH 4/4] s390x: Beautify machine reset Janosch Frank
2019-11-22 10:59 ` David Hildenbrand
2019-11-22 11:46 ` Janosch Frank
2019-11-22 11:47 ` David Hildenbrand
2019-11-22 12:10 ` Cornelia Huck
2019-11-22 12:22 ` Janosch Frank
2019-11-22 12:25 ` David Hildenbrand
2019-11-22 12:30 ` Janosch Frank
2019-11-22 12:42 ` David Hildenbrand
2019-11-22 10:10 ` [PATCH 0/4] s390x: Reset cleanup no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4793f8ae-a709-2a41-ea71-4197a026b58a@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=mihajlov@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).