From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JJVcG-0000FP-Tu
	for qemu-devel@nongnu.org; Mon, 28 Jan 2008 10:09:44 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JJVcF-0000FA-1U
	for qemu-devel@nongnu.org; Mon, 28 Jan 2008 10:09:44 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JJVcE-0000F7-Ua
	for qemu-devel@nongnu.org; Mon, 28 Jan 2008 10:09:42 -0500
Received: from smtp02.citrix.com ([66.165.176.63])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <stefano.stabellini@citrix.com>) id 1JJVcF-0003go-76
	for qemu-devel@nongnu.org; Mon, 28 Jan 2008 10:09:43 -0500
Received: from [172.31.33.111] (host217-46-209-99.in-addr.btopenworld.com
	[217.46.209.99]) (authenticated bits=0)
	by smtp01.ad.xensource.com (8.13.1/8.13.1) with ESMTP id m0SF8vEK020498
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <qemu-devel@nongnu.org>; Mon, 28 Jan 2008 07:08:59 -0800
Message-ID: <479DEFF9.5080706@citrix.com>
Date: Mon, 28 Jan 2008 15:08:41 +0000
From: Stefano Stabellini <stefano.stabellini@citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] mouse click simple queue
References: <479DC0F0.5050205@citrix.com> <87fxwi2l50.fsf@an-dro.enstb.org>
	<20080128123136.GK4267@implementation.uk.xensource.com>
In-Reply-To: <20080128123136.GK4267@implementation.uk.xensource.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Samuel Thibault wrote:
> Ronan Keryell, le Mon 28 Jan 2008 13:24:27 +0100, a écrit :
>> But is it possible to use higher-level queue constructions rather than
>> inlining the queue behaviour in the code?
> 
> There is QEMUFIFO code in console.c which could be shared for instance,
> yes.
> 

QEMUFIFO cannot be used directly for the mouse click queue.
What can be done is writing a generic queue library independent from the 
type of the elements. Then we could use the library wherever needed.
If you think that it is a good idea I'll post a patch that implements 
this kind of library.