From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JKjlT-0003iI-TX
	for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:28:19 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JKjlS-0003hn-F8
	for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:28:19 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JKjlS-0003hk-9I
	for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:28:18 -0500
Received: from e3.ny.us.ibm.com ([32.97.182.143])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1JKjlS-00049o-7v
	for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:28:18 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e3.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m110SASA020617
	for <qemu-devel@nongnu.org>; Thu, 31 Jan 2008 19:28:10 -0500
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id
	m110SAbj201162
	for <qemu-devel@nongnu.org>; Thu, 31 Jan 2008 19:28:10 -0500
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	m110S9Bn026665
	for <qemu-devel@nongnu.org>; Thu, 31 Jan 2008 19:28:09 -0500
Message-ID: <47A26790.6010609@us.ibm.com>
Date: Thu, 31 Jan 2008 18:28:00 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1201818980-27534-1-git-send-email-aliguori@us.ibm.com>
	<1201818980-27534-5-git-send-email-aliguori@us.ibm.com>
	<200802010014.07960.paul@codesourcery.com>
In-Reply-To: <200802010014.07960.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 4/6] Tell BIOS about the number of CPUs
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org

Paul Brook wrote:
>> -    cmos_init(ram_size, above_4g_mem_size, boot_device, hd);
>> +    cmos_init(ram_size, above_4g_mem_size, boot_device, hd, smp_cpus);
>>     
>
> smp_cpus is a global variable. Why bother passing it around?
>   

True, I'll update the patch

> Are the CMOS contents documented anywhere?
>   

No, but if you have a suggestion of where to document them, I'll add 
documentation.

Regards,

Anthony Liguori

> Paul
>