From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JKjxB-0003nx-B9 for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:40:25 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JKjx8-0003km-Jb for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:40:24 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JKjx8-0003kd-G9 for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:40:22 -0500 Received: from e35.co.us.ibm.com ([32.97.110.153]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JKjx8-0005TJ-AD for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:40:22 -0500 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e35.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m110eKNE013004 for ; Thu, 31 Jan 2008 19:40:20 -0500 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m110eKUR197988 for ; Thu, 31 Jan 2008 17:40:20 -0700 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m110eJP5006100 for ; Thu, 31 Jan 2008 17:40:20 -0700 Message-ID: <47A26A75.5000900@us.ibm.com> Date: Thu, 31 Jan 2008 18:40:21 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1201818980-27534-1-git-send-email-aliguori@us.ibm.com> <200801312354.24382.paul@codesourcery.com> <47A26714.4000204@us.ibm.com> <200802010037.30731.paul@codesourcery.com> In-Reply-To: <200802010037.30731.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/6] Use correct types to enable > 2G support Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: kvm-devel@lists.sourceforge.net, Izik Eidus , qemu-devel@nongnu.org Paul Brook wrote: >>>> +#define PHYS_RAM_MAX_SIZE (2047 * 1024 * 1024 * 1024ULL) >>>> >>> This seems fairly arbitrary. Why? Any limit is certainly target specific. >>> >> On a 32-bit host, a 2GB limit is pretty reasonable since you're limited >> in virtual address space. On a 64-bit host, there isn't this >> fundamental limit. If a target may have it's own limit but there is >> definitely a host imposed limit. >> >> 2047GBs is a somewhat arbitrary limit though for 64-bit hosts. If you >> have a more logical suggestion, I'll happily change it. >> > > Don't have a limit at all. > > The reason we have the current 31-bit limit is because qemu is/was known to > use a signed int do hold the size. With your code 64-bit hosts should be able > to handle anything atoi can parse. > > As mentioned on IRC, I also noticed that ram_save hasn't been updated. > Okay, I'll update both of these. Regards, Anthony Liguori > Paul >