[Qemu-devel] qemu-img convert does not handle -O correctly

[Qemu-devel] qemu-img convert does not handle -O correctly

[Andreas Färber]

Hello,

When running `qemu-img convert haikuware.vmdk -O qcow2  
haikuware.qcow2` on OSX, it complains it cannot open '-O'.

According to `qemu-img convert --help` my syntax is correct.

Andreas

Re: [Qemu-devel] qemu-img convert does not handle -O correctly

[Dean Payne]

Andreas Färber wrote:
> Hello,
>
> When running `qemu-img convert haikuware.vmdk -O qcow2 
> haikuware.qcow2` on OSX, it complains it cannot open '-O'.
>
> According to `qemu-img convert --help` my syntax is correct.
>
> Andreas
>
>

I had similar problems and needed to change the order of parameters on 
the command line.

For your statement try...

qemu-img convert -f vmdk -O qcow2 haikuware.vmdk haikuware.qcow2

... as -f and -O come first before filenames

[PATCH] Re: [Qemu-devel] qemu-img convert does not handle -O correctly

[Andreas Färber]

[-- Attachment #1: Type: text/plain, Size: 644 bytes --]


Am 04.02.2008 um 00:41 schrieb Dean Payne:

>
> Andreas Färber wrote:
>> Hello,
>>
>> When running `qemu-img convert haikuware.vmdk -O qcow2  
>> haikuware.qcow2` on OSX, it complains it cannot open '-O'.
>>
>> According to `qemu-img convert --help` my syntax is correct.
>>
>> Andreas
>>
>>
>
> I had similar problems and needed to change the order of parameters  
> on the command line.
>
> For your statement try...
>
> qemu-img convert -f vmdk -O qcow2 haikuware.vmdk haikuware.qcow2
>
> ... as -f and -O come first before filenames

Thanks, that did work. Attached is a patch to fix the usage output.

Andreas

[-- Attachment #2: qemu-img-O.diff --]
[-- Type: application/octet-stream, Size: 747 bytes --]

Index: qemu-img.c
===================================================================
RCS file: /sources/qemu/qemu/qemu-img.c,v
retrieving revision 1.28
diff -u -r1.28 qemu-img.c
--- qemu-img.c	6 Jan 2008 17:21:48 -0000	1.28
+++ qemu-img.c	4 Feb 2008 22:27:13 -0000
@@ -90,7 +90,7 @@
            "Command syntax:\n"
            "  create [-e] [-6] [-b base_image] [-f fmt] filename [size]\n"
            "  commit [-f fmt] filename\n"
-           "  convert [-c] [-e] [-6] [-f fmt] filename [filename2 [...]] [-O output_fmt] output_filename\n"
+           "  convert [-c] [-e] [-6] [-f fmt] [-O output_fmt] filename [filename2 [...]] output_filename\n"
            "  info [-f fmt] filename\n"
            "\n"
            "Command parameters:\n"

[-- Attachment #3: Type: text/plain, Size: 1 bytes --]