From: Anthony Liguori <anthony@codemonkey.ws>
To: Izik Eidus <izike@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net,
Paul Brook <paul@codesourcery.com>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2)
Date: Sun, 03 Feb 2008 19:56:04 -0600 [thread overview]
Message-ID: <47A670B4.6020803@codemonkey.ws> (raw)
In-Reply-To: <1201903921-1125-3-git-send-email-aliguori@us.ibm.com>
Hi Izik,
Anthony Liguori wrote:
> Index: qemu/cpu-all.h
> ===================================================================
> --- qemu.orig/cpu-all.h 2008-02-01 15:24:45.000000000 -0600
> +++ qemu/cpu-all.h 2008-02-01 15:28:48.000000000 -0600
> @@ -695,7 +695,7 @@
>
> /* page related stuff */
>
> -#define TARGET_PAGE_SIZE (1 << TARGET_PAGE_BITS)
> +#define TARGET_PAGE_SIZE (1ul << TARGET_PAGE_BITS)
> #define TARGET_PAGE_MASK ~(TARGET_PAGE_SIZE - 1)
> #define TARGET_PAGE_ALIGN(addr) (((addr) + TARGET_PAGE_SIZE - 1) & TARGET_PAGE_MASK
Do you recall what this change fixed? As Paul pointed out in IRC, using
the host type here doesn't really fix the problem (target_ulong would be
more appropriate). However, we're both curious what problem it's
actually fixing since sign extending the int should just work.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-02-04 1:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 22:11 [Qemu-devel] [PATCH 0/6] Support for the Kernel Virtual Machine interface (v2) Anthony Liguori
2008-02-01 22:11 ` [Qemu-devel] [PATCH 1/6] Fix VMware VGA init call Anthony Liguori
2008-02-01 22:23 ` [Qemu-devel] " Anthony Liguori
2008-02-01 22:11 ` [Qemu-devel] [PATCH 2/6] Use correct types to enable > 2G support (v2) Anthony Liguori
2008-02-04 1:56 ` Anthony Liguori [this message]
2008-02-04 8:45 ` [Qemu-devel] " Izik Eidus
2008-02-04 15:31 ` Anthony Liguori
2008-02-10 10:48 ` Avi Kivity
2008-02-10 14:12 ` Paul Brook
2008-02-10 14:55 ` Avi Kivity
2008-02-10 14:59 ` Paul Brook
2008-02-10 15:14 ` Avi Kivity
2008-02-01 22:11 ` [Qemu-devel] [PATCH 3/6] SCI fixes (v2) Anthony Liguori
2008-02-01 22:11 ` [Qemu-devel] [PATCH 4/6] Fix daemonize options (v2) Anthony Liguori
2008-02-01 22:12 ` [Qemu-devel] [PATCH 5/6] Tell BIOS about the number of CPUs (v2) Anthony Liguori
2008-02-01 22:12 ` [Qemu-devel] [PATCH 6/6] QEMU support for the Kernel Virtual Machine interface (v2) Anthony Liguori
2008-02-04 13:51 ` Soren Hansen
2008-02-04 15:14 ` [kvm-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A670B4.6020803@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=izike@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).