From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JLqZB-0005HL-Ex
	for qemu-devel@nongnu.org; Sun, 03 Feb 2008 20:56:13 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JLqZ9-0005Gr-Sx
	for qemu-devel@nongnu.org; Sun, 03 Feb 2008 20:56:13 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JLqZ9-0005Go-QV
	for qemu-devel@nongnu.org; Sun, 03 Feb 2008 20:56:11 -0500
Received: from an-out-0708.google.com ([209.85.132.250])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1JLqZ9-0004zE-Ji
	for qemu-devel@nongnu.org; Sun, 03 Feb 2008 20:56:11 -0500
Received: by an-out-0708.google.com with SMTP id b38so573515ana.130
	for <qemu-devel@nongnu.org>; Sun, 03 Feb 2008 17:56:09 -0800 (PST)
Message-ID: <47A670B4.6020803@codemonkey.ws>
Date: Sun, 03 Feb 2008 19:56:04 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1201903921-1125-1-git-send-email-aliguori@us.ibm.com>
	<1201903921-1125-3-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1201903921-1125-3-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G
	support (v2)
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Izik Eidus <izike@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net, Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

Hi Izik,

Anthony Liguori wrote:
> Index: qemu/cpu-all.h
> ===================================================================
> --- qemu.orig/cpu-all.h	2008-02-01 15:24:45.000000000 -0600
> +++ qemu/cpu-all.h	2008-02-01 15:28:48.000000000 -0600
> @@ -695,7 +695,7 @@
>  
>  /* page related stuff */
>  
> -#define TARGET_PAGE_SIZE (1 << TARGET_PAGE_BITS)
> +#define TARGET_PAGE_SIZE (1ul << TARGET_PAGE_BITS)
>  #define TARGET_PAGE_MASK ~(TARGET_PAGE_SIZE - 1)
>  #define TARGET_PAGE_ALIGN(addr) (((addr) + TARGET_PAGE_SIZE - 1) & TARGET_PAGE_MASK

Do you recall what this change fixed?  As Paul pointed out in IRC, using 
the host type here doesn't really fix the problem (target_ulong would be 
more appropriate).  However, we're both curious what problem it's 
actually fixing since sign extending the int should just work.

Regards,

Anthony Liguori