From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JSgOm-0006uX-Oe
	for qemu-devel@nongnu.org; Fri, 22 Feb 2008 17:29:44 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JSgOm-0006uE-1O
	for qemu-devel@nongnu.org; Fri, 22 Feb 2008 17:29:44 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JSgOl-0006uB-Sq
	for qemu-devel@nongnu.org; Fri, 22 Feb 2008 17:29:43 -0500
Received: from ti-out-0910.google.com ([209.85.142.189])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1JSgOl-0004NK-Oo
	for qemu-devel@nongnu.org; Fri, 22 Feb 2008 17:29:44 -0500
Received: by ti-out-0910.google.com with SMTP id d10so518785tib.18
	for <qemu-devel@nongnu.org>; Fri, 22 Feb 2008 14:29:40 -0800 (PST)
Message-ID: <47BF4CD1.3090506@codemonkey.ws>
Date: Fri, 22 Feb 2008 16:29:37 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1203709210-23314-1-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1203709210-23314-1-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [kvm-devel] [PATCH] Don't explicitly set BAR
 values for VMware VGA
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org

Anthony Liguori wrote:
> Right now we set explict base addresses for the PCI IO regions in the VMware
> VGA device.  We don't register the second region at all and instead directly
> map the physical memory.
>
> The problem is, the addresses we're setting in the BAR is not taken into
> account in the e820 mapping.
>   

Actually, it looks like the e820 map is okay, but I do get some errors 
in the gust about remapping that range so I do think this patch is correct.

Regards,

Anthony Liguori

> This patch removes the explicit BARs and registers the second region through
> the normal PCI code.
>
> I've only tested with a Linux guest and the open source VMware VGA driver.
>
> This patch needs -p2 to apply against the QEMU CVS tree.
>
>