From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JShsC-0004Gk-1c for qemu-devel@nongnu.org; Fri, 22 Feb 2008 19:04:12 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JShs9-0004F8-7B for qemu-devel@nongnu.org; Fri, 22 Feb 2008 19:04:11 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JShs8-0004F3-Tj for qemu-devel@nongnu.org; Fri, 22 Feb 2008 19:04:08 -0500 Received: from e36.co.us.ibm.com ([32.97.110.154]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JShs8-00056r-JP for qemu-devel@nongnu.org; Fri, 22 Feb 2008 19:04:08 -0500 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e36.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m1N040Ap011652 for ; Fri, 22 Feb 2008 19:04:00 -0500 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m1N0404B221018 for ; Fri, 22 Feb 2008 17:04:00 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m1N040pe002371 for ; Fri, 22 Feb 2008 17:04:00 -0700 Message-ID: <47BF62DF.3090400@us.ibm.com> Date: Fri, 22 Feb 2008 18:03:43 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1203709210-23314-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Don't explicitly set BAR values for VMware VGA Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: andrzej zaborowski Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org andrzej zaborowski wrote: > On 22/02/2008, Anthony Liguori wrote: > >> Right now we set explict base addresses for the PCI IO regions in the VMware >> VGA device. We don't register the second region at all and instead directly >> map the physical memory. >> >> The problem is, the addresses we're setting in the BAR is not taken into >> account in the e820 mapping. >> >> This patch removes the explicit BARs and registers the second region through >> the normal PCI code. >> >> I've only tested with a Linux guest and the open source VMware VGA driver. >> > > I have a very similar patch on my HD but I haven't included it because > it causes my testing Ms Windows install to stop detecting the card. I > just tested your patch and the same thing happens, i.e. with the patch > it works as a vga card but is detected as an Unknown adapter and only > the 640x480x8 mode can be used. I can't explain this. > Can you describe how you setup your Windows install? I'll try to reproduce it and dig into it. Regards, Anthony Liguori > Currently the io port numbers can be set by the guest and the memory > io regions are fixed. Earlier both settings were hardcoded. This is > because in one version of the X driver (which was/is the only > documentation available) these settings were metioned as *the* correct > values for this card. This may of course cause different types of > breakage but so far worked ok, except when it was found that in > various combinations qemu segfaulted due to different PCI cards > registering the same port range as our default. When this happened I > tried to make these settings settable through PCI registers but found > that this broke Ms Windows. Luckily Ms Windows still worked if only > port ranges were assigned dynamically and the segfault went away so I > left it at this but it perhaps needs better looking at. >