* [Qemu-devel] [PATCH] hw/slavio_timer.c remove unneeded qemu_irq_lower
@ 2008-03-03 0:44 Robert Reif
0 siblings, 0 replies; only message in thread
From: Robert Reif @ 2008-03-03 0:44 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 128 bytes --]
Remove unneeded qemu_irq_lower because user mode timers don't support
IRQs and the IRQ is lowered when switching to user mode.
[-- Attachment #2: timer.diff.txt --]
[-- Type: text/plain, Size: 751 bytes --]
diff -p -u -r1.30 slavio_timer.c
--- hw/slavio_timer.c 26 Jan 2008 09:13:46 -0000 1.30
+++ hw/slavio_timer.c 3 Mar 2008 00:35:28 -0000
@@ -192,7 +192,6 @@ static void slavio_timer_mem_writel(void
uint64_t count;
// set user counter MSW, reset counter
- qemu_irq_lower(s->irq);
s->limit = TIMER_MAX_COUNT64;
s->counthigh = val & (TIMER_MAX_COUNT64 >> 32);
s->reached = 0;
@@ -218,7 +217,6 @@ static void slavio_timer_mem_writel(void
uint64_t count;
// set user counter LSW, reset counter
- qemu_irq_lower(s->irq);
s->limit = TIMER_MAX_COUNT64;
s->count = val & TIMER_MAX_COUNT64;
s->reached = 0;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-03-03 0:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-03 0:44 [Qemu-devel] [PATCH] hw/slavio_timer.c remove unneeded qemu_irq_lower Robert Reif
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).