From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JZDDH-0002QR-JP
	for qemu-devel@nongnu.org; Tue, 11 Mar 2008 18:44:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JZDDF-0002QF-0v
	for qemu-devel@nongnu.org; Tue, 11 Mar 2008 18:44:50 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JZDDE-0002QC-Qt
	for qemu-devel@nongnu.org; Tue, 11 Mar 2008 18:44:48 -0400
Received: from relay4-v.mail.gandi.net ([217.70.178.78])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fabrice@bellard.org>) id 1JZDDE-0001TC-FP
	for qemu-devel@nongnu.org; Tue, 11 Mar 2008 18:44:48 -0400
Received: from localhost (mfilter5-v.gandi.net [217.70.178.39])
	by relay4-v.mail.gandi.net (Postfix) with ESMTP id 37815BA26
	for <qemu-devel@nongnu.org>; Tue, 11 Mar 2008 23:44:47 +0100 (CET)
Received: from relay4-v.mail.gandi.net ([217.70.178.78])
	by localhost (mfilter5-v.gandi.net [217.70.178.39]) (amavisd-new,
	port 10024) with ESMTP id Ego-92sywnOo for <qemu-devel@nongnu.org>;
	Tue, 11 Mar 2008 23:31:39 +0100 (CET)
Received: from [86.73.70.43] (unknown [86.73.70.43])
	by relay4-v.mail.gandi.net (Postfix) with ESMTP id 89EC9BA2E
	for <qemu-devel@nongnu.org>; Tue, 11 Mar 2008 23:44:30 +0100 (CET)
Message-ID: <47D70B23.6090805@bellard.org>
Date: Tue, 11 Mar 2008 23:43:47 +0100
From: Fabrice Bellard <fabrice@bellard.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...
References: <E1JZ86x-0004mP-EW@cvs.savannah.gnu.org>	<47D6C1B5.2090002@bellard.org>
	<47D7066B.80109@aurel32.net>
In-Reply-To: <47D7066B.80109@aurel32.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Aurelien Jarno wrote:
> Fabrice Bellard a =E9crit :
>> IMHO it would be much simpler to do all the tests in the block format
>> handlers.
>>
>=20
> Do you mean move all the tests into block-{qcow,qcow2,vmdk}.c ?

I suggest reverting the patch and writing correct tests in
block-{qcow,qcow2,vmdk}.c. BTW, bs->total_sectors is not a good
indicator of the device size in case of removable devices for example.

Fabrice.