From: Avi Kivity <avi@qumranet.com>
To: Paul Brook <paul@codesourcery.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>, qemu-devel@nongnu.org
Subject: Re: [kvm-devel] [Qemu-devel] [PATCH] [RFC] Fix time drift of rtc clock + general support
Date: Mon, 24 Mar 2008 09:11:40 +0200 [thread overview]
Message-ID: <47E7542C.60901@qumranet.com> (raw)
In-Reply-To: <200803231619.32472.paul@codesourcery.com>
Paul Brook wrote:
> On Sunday 23 March 2008, Dor Laor wrote:
>
>> --- a/qemu/hw/irq.c
>> +++ b/qemu/hw/irq.c
>> @@ -30,6 +30,8 @@ struct IRQState {
>> int n;
>> };
>>
>> +uint32_t qemu_irq_acked[NR_IRQ_WORDS];
>>
>
> This is absolute rubbish. The whole point of the IRQ framework is that it
> doesn't assume a single flat IRQ controller.
>
>
x86 does have a single irq space (even when using cascaded pics or
multiple ioapics), called gsi (for generalized system interrupt, or
something). It is possible to enumerate all irqs on all platforms that
have a finite number of them.
It may be better though to identify an irq by a (controller_id,
irq_line) pair instead.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2008-03-24 9:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-23 14:27 [Qemu-devel] [PATCH] [RFC] Fix time drift of rtc clock + general support Dor Laor
2008-03-23 16:19 ` Paul Brook
2008-03-23 22:40 ` Dor Laor
2008-03-23 23:29 ` Paul Brook
2008-03-24 7:15 ` [kvm-devel] " Avi Kivity
2008-03-24 7:47 ` Avi Kivity
2008-03-24 7:11 ` Avi Kivity [this message]
2008-03-24 13:45 ` Paul Brook
2008-03-24 13:56 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E7542C.60901@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).