* [Qemu-devel] [PATCH] [MIPS] Fix infinite loop when invalidating TLB
@ 2008-03-29 18:24 Hervé Poussineau
0 siblings, 0 replies; only message in thread
From: Hervé Poussineau @ 2008-03-29 18:24 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 257 bytes --]
Hi,
In certain conditions, MIPS R4K TLB invalidation can lead to an infinite
loop.
If 'end' address is 0xffffffffffffffff, invalidation loop should stop
once 'addr' has flushed address 0xfffffffffffff000.
Attached patch fixes this issue.
Hervé
[-- Attachment #2: invalidate_last_page.patch --]
[-- Type: text/plain, Size: 539 bytes --]
Index: target-mips/helper.c
===================================================================
RCS file: /sources/qemu/qemu/target-mips/helper.c,v
retrieving revision 1.63
diff -u -r1.63 target-mips/helper.c
--- target-mips/helper.c 4 Jan 2008 17:52:57 -0000 1.63
+++ target-mips/helper.c 28 Mar 2008 07:47:46 -0000
@@ -630,7 +630,7 @@
}
#endif
end = addr | mask;
- while (addr < end) {
+ while (addr - 1 < end) {
tlb_flush_page (env, addr);
addr += TARGET_PAGE_SIZE;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-03-29 18:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-29 18:24 [Qemu-devel] [PATCH] [MIPS] Fix infinite loop when invalidating TLB Hervé Poussineau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).