From: Avi Kivity <avi@qumranet.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Improve DMA transfers by increasing the buffer size.
Date: Sun, 30 Mar 2008 13:42:01 +0300 [thread overview]
Message-ID: <47EF6E79.8010406@qumranet.com> (raw)
In-Reply-To: <18412.55320.507537.335497@mariner.uk.xensource.com>
Ian Jackson wrote:
> Aurelien Jarno writes ("Re: [Qemu-devel] [PATCH] Improve DMA transfers by increasing the buffer size."):
>
>> On Wed, Mar 26, 2008 at 04:35:00PM +0000, Ian Jackson wrote:
>> Content-Description: message body text
>>
>>> +#define IDE_DMA_BUF_SIZE 131072
>>>
>> Wouldn't it be better to define this value in number of sectors? This
>> would avoid a few divisions in the code, and anyway the code handling
>> DMA transfers is working with a number of sectors, not a number of
>> bytes.
>>
>
> I don't have much of an opinion about what units it should be in. The
> divisions are just at compile-time of course.
>
>
I prefer bytes myself, this way it is easy to have all constants using
the same scale factor (1) and avoid worrying about conversions, except
at the last moment when using them.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-03-30 10:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 16:35 [Qemu-devel] [PATCH] Improve DMA transfers by increasing the buffer size Ian Jackson
2008-03-27 23:53 ` Aurelien Jarno
2008-03-28 10:05 ` Samuel Thibault
2008-03-28 11:35 ` Ian Jackson
2008-03-28 16:22 ` Aurelien Jarno
2008-03-29 12:16 ` Aurelien Jarno
2008-03-31 15:25 ` Ian Jackson
2008-03-30 10:42 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EF6E79.8010406@qumranet.com \
--to=avi@qumranet.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).