From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Jhymi-0001oh-NL
	for qemu-devel@nongnu.org; Fri, 04 Apr 2008 23:09:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Jhymh-0001oR-Bn
	for qemu-devel@nongnu.org; Fri, 04 Apr 2008 23:09:40 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Jhymh-0001oO-5x
	for qemu-devel@nongnu.org; Fri, 04 Apr 2008 23:09:39 -0400
Received: from an-out-0708.google.com ([209.85.132.244])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Jhymh-00044p-0X
	for qemu-devel@nongnu.org; Fri, 04 Apr 2008 23:09:39 -0400
Received: by an-out-0708.google.com with SMTP id d26so100702and.130
	for <qemu-devel@nongnu.org>; Fri, 04 Apr 2008 20:09:32 -0700 (PDT)
Message-ID: <47F6ED68.5090200@codemonkey.ws>
Date: Fri, 04 Apr 2008 22:09:28 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/6] virtio for QEMU
References: <1206827760-4566-1-git-send-email-aliguori@us.ibm.com>	<1206827760-4566-3-git-send-email-aliguori@us.ibm.com>
	<1206897941.3357.15.camel@localhost.localdomain>
In-Reply-To: <1206897941.3357.15.camel@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: dor.laor@qumranet.com
Cc: kvm-devel@lists.sourceforge.net, Marcelo Tosatti <marcelo@kvack.org>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>

Dor Laor wrote:
> 
>> +static uint32_t vring_desc_len(VirtQueue *vq, unsigned int i)
>> +{
> 
> Below there were place you did use offsetof(vq->vring.desc[i], len) so
> we better be consistent + its nicer
> 
>> +    return ldl_phys(vq->vring.desc + i * sizeof(VRingDesc) + 
>> +		    offsetof(VRingDesc, len));
>> +}
>> +

Oh, this bit is different because you need to do offsetof(Type, member) 
and vq->vring.desc[i] is not a type.  It only works when you're doing an 
array with member[X].

Regards,

Anthony Liguori