From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JirOn-00079G-Bd for qemu-devel@nongnu.org; Mon, 07 Apr 2008 09:28:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JirOi-00076Z-MG for qemu-devel@nongnu.org; Mon, 07 Apr 2008 09:28:36 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JirOi-00076D-Fa for qemu-devel@nongnu.org; Mon, 07 Apr 2008 09:28:32 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JirOi-0007DM-6R for qemu-devel@nongnu.org; Mon, 07 Apr 2008 09:28:32 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m37DMOGx008517 for ; Mon, 7 Apr 2008 09:22:24 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m37DMOuZ041154 for ; Mon, 7 Apr 2008 09:22:24 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m37DMOCA014809 for ; Mon, 7 Apr 2008 09:22:24 -0400 Message-ID: <47FA200F.8080106@us.ibm.com> Date: Mon, 07 Apr 2008 08:22:23 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/6] Use ram_addr_t for cpu_get_physical_page_desc (v2) References: <1207368175-19476-1-git-send-email-aliguori@us.ibm.com> <200804062241.08188.paul@codesourcery.com> In-Reply-To: <200804062241.08188.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: Marcelo Tosatti , qemu-devel@nongnu.org, Aurelien Jarno Paul Brook wrote: > On Friday 04 April 2008 23:02:50 Anthony Liguori wrote: > >> uint32_t is the wrong type to use to represent physical addresses. >> .... >> /* XXX: temporary until new memory mapping API */ >> -uint32_t cpu_get_physical_page_desc(target_phys_addr_t addr) >> +ram_addr_t cpu_get_physical_page_desc(target_phys_addr_t addr) >> > > The returned value is still a uint32_t. Changing the function prototype > without fixing that is just deluding yourself. > It's a ram_addr_t in KVM and the large mem patch I posted long ago changes it to a ram_addr_t. But you're right, it doesn't belong in this series. Regards, Anhtony Liguori > Paul >