From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JkFcc-0004Jc-89 for qemu-devel@nongnu.org; Fri, 11 Apr 2008 05:32:38 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JkFcb-0004Ix-Ff for qemu-devel@nongnu.org; Fri, 11 Apr 2008 05:32:37 -0400 Received: from mx1.polytechnique.org ([129.104.30.34]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JkFcb-0006kv-3X for qemu-devel@nongnu.org; Fri, 11 Apr 2008 05:32:37 -0400 Received: from fbe1.dev.netgem.com (gw.netgem.com [195.68.2.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTP id 57C033316C for ; Fri, 11 Apr 2008 11:32:11 +0200 (CEST) Message-ID: <47FF301A.4010808@bellard.org> Date: Fri, 11 Apr 2008 11:32:10 +0200 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] tcg_target_prologue() References: <20080411005722.GA29173@miranda.arrow> In-Reply-To: <20080411005722.GA29173@miranda.arrow> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stuart Brady wrote: > Hi, > > I recently tried using the C version of the TB call in cpu-exec.c, > "T0 = gen_func();", with HPPA host support. However, I must then save > the link register, or else it would be overwritten... but if I use > tcg_target_prologue(), I find that goto_tb sometimes jumps to the > prologue, but it sometimes jumps past the prologue, instead! > > I've fixed the bug[1] that caused me to investigate this, so for the > time being, I'll continue calling TBs from inline assembly code, but it > might be nice to spare others the pain of trying tcg_target_prologue() > and failing. Any thoughts? The real fix is in the TCG TODO list (global prologue and epilogue). I will try to implement it ASAP. Regards, Fabrice.