From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JkFdf-0004ko-Rh
	for qemu-devel@nongnu.org; Fri, 11 Apr 2008 05:33:43 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JkFdf-0004kR-BO
	for qemu-devel@nongnu.org; Fri, 11 Apr 2008 05:33:43 -0400
Received: from mx1.polytechnique.org ([129.104.30.34])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <fabrice@bellard.org>) id 1JkFde-00072Z-Vi
	for qemu-devel@nongnu.org; Fri, 11 Apr 2008 05:33:43 -0400
Received: from fbe1.dev.netgem.com (gw.netgem.com [195.68.2.34])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by ssl.polytechnique.org (Postfix) with ESMTP id 3C4C63316C
	for <qemu-devel@nongnu.org>; Fri, 11 Apr 2008 11:33:39 +0200 (CEST)
Message-ID: <47FF3071.5070107@bellard.org>
Date: Fri, 11 Apr 2008 11:33:37 +0200
From: Fabrice Bellard <fabrice@bellard.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [4188] Fix compiler warnings
References: <E1JkBID-0000EB-B9@cvs.savannah.gnu.org>
In-Reply-To: <E1JkBID-0000EB-B9@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

It would be better to use the gcc noreturn function attribute !

Fabrice.

Aurelien Jarno wrote:
> Revision: 4188
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4188
> Author:   aurel32
> Date:     2008-04-11 04:55:17 +0000 (Fri, 11 Apr 2008)
> 
> Log Message:
> -----------
> Fix compiler warnings
> 
> (Stefan Weil)
> 
> Modified Paths:
> --------------
>     trunk/cpu-exec.c
> 
> Modified: trunk/cpu-exec.c
> ===================================================================
> --- trunk/cpu-exec.c	2008-04-11 04:55:07 UTC (rev 4187)
> +++ trunk/cpu-exec.c	2008-04-11 04:55:17 UTC (rev 4188)
> @@ -882,6 +882,8 @@
>         do it (XXX: use sigsetjmp) */
>      sigprocmask(SIG_SETMASK, old_set, NULL);
>      cpu_loop_exit();
> +    /* never comes here */
> +    return 1;
>  }
>  #elif defined(TARGET_SPARC)
>  static inline int handle_cpu_signal(unsigned long pc, unsigned long address,
> @@ -918,6 +920,8 @@
>         do it (XXX: use sigsetjmp) */
>      sigprocmask(SIG_SETMASK, old_set, NULL);
>      cpu_loop_exit();
> +    /* never comes here */
> +    return 1;
>  }
>  #elif defined (TARGET_PPC)
>  static inline int handle_cpu_signal(unsigned long pc, unsigned long address,
> 
> 
> 
> 
>