From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JkOgt-00016m-9P
	for qemu-devel@nongnu.org; Fri, 11 Apr 2008 15:13:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JkOgr-00016S-QI
	for qemu-devel@nongnu.org; Fri, 11 Apr 2008 15:13:39 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JkOgr-00016L-Ji
	for qemu-devel@nongnu.org; Fri, 11 Apr 2008 15:13:37 -0400
Received: from moutng.kundenserver.de ([212.227.126.171])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1JkOgr-00059j-GM
	for qemu-devel@nongnu.org; Fri, 11 Apr 2008 15:13:37 -0400
Message-ID: <47FFB85E.70300@mail.berlios.de>
Date: Fri, 11 Apr 2008 21:13:34 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [4188] Fix compiler warnings
References: <E1JkBID-0000EB-B9@cvs.savannah.gnu.org>
	<47FF3071.5070107@bellard.org>
In-Reply-To: <47FF3071.5070107@bellard.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

In this special case, this is not possible without some dirty tricks:

The attribute must be assigned to cpu_loop_exit.
cpu_loop_exit would no longer end with an assembler return, so dyngen 
will fail.

Maybe my dummy return is the better solution for the moment
Several architectures used this solution before my patch.

Stefan

Fabrice Bellard schrieb:
> It would be better to use the gcc noreturn function attribute !
>
> Fabrice.
>
> Aurelien Jarno wrote:
>> Revision: 4188
>>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4188
>> Author:   aurel32
>> Date:     2008-04-11 04:55:17 +0000 (Fri, 11 Apr 2008)
>>
>> Log Message:
>> -----------
>> Fix compiler warnings
>>
>> (Stefan Weil)
>>
>> Modified Paths:
>> --------------
>>     trunk/cpu-exec.c
>>
>> Modified: trunk/cpu-exec.c
>> ===================================================================
>> --- trunk/cpu-exec.c    2008-04-11 04:55:07 UTC (rev 4187)
>> +++ trunk/cpu-exec.c    2008-04-11 04:55:17 UTC (rev 4188)
>> @@ -882,6 +882,8 @@
>>         do it (XXX: use sigsetjmp) */
>>      sigprocmask(SIG_SETMASK, old_set, NULL);
>>      cpu_loop_exit();
>> +    /* never comes here */
>> +    return 1;
>>  }
>>  #elif defined(TARGET_SPARC)
>>  static inline int handle_cpu_signal(unsigned long pc, unsigned long 
>> address,
>> @@ -918,6 +920,8 @@
>>         do it (XXX: use sigsetjmp) */
>>      sigprocmask(SIG_SETMASK, old_set, NULL);
>>      cpu_loop_exit();
>> +    /* never comes here */
>> +    return 1;
>>  }
>>  #elif defined (TARGET_PPC)
>>  static inline int handle_cpu_signal(unsigned long pc, unsigned long 
>> address,
>>
>>
>>
>>
>>
>
>
>
>