qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Doug Evans <dje@google.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] qom/object.c: Fix typo
Date: Fri, 12 Feb 2021 10:38:25 +0100	[thread overview]
Message-ID: <47ac533c-b04e-76e0-0d84-fdff05be71e7@redhat.com> (raw)
In-Reply-To: <000000000000530c7105bb191b33@google.com>

Hi Doug,

On 2/12/21 1:56 AM, Doug Evans via wrote:
> A simple typo (noticed by inspection).
> 
> commit ccdffd2c10c5e4447d5e462a6ad2f351df502dee
> Author: Doug Evans <dje@google.com>
> Date:   Thu Feb 11 16:29:13 2021 -0800
> 
>     qom/object.c: Fix typo
>     
>     Signed-off-by: Doug Evans <dje@google.com>

Your patch can be applied with git-am, but with author
Doug Evans via <qemu-devel@nongnu.org> and contains an invalid
commit reference.

Can you use git-format-patch which inserts a From: tag so your
email is properly set and you don't have to worry with the issues
with your email provider:
https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch

> diff --git a/qom/object.c b/qom/object.c
> index 491823db4a..6a01d56546 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -695,7 +695,7 @@ static void object_finalize(void *data)
>  
>  /* Find the minimum alignment guaranteed by the system malloc. */
>  #if __STDC_VERSION__ >= 201112L
> -typddef max_align_t qemu_max_align_t;
> +typedef max_align_t qemu_max_align_t;
>  #else
>  typedef union {
>      long l;
> 

For the typo:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



      reply	other threads:[~2021-02-12  9:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12  0:56 [PATCH] qom/object.c: Fix typo Doug Evans via
2021-02-12  9:38 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47ac533c-b04e-76e0-0d84-fdff05be71e7@redhat.com \
    --to=philmd@redhat.com \
    --cc=dje@google.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).