From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Cc: Aleksandar Rikalo <arikalo@wavecomp.com>,
Aleksandar Markovic <amarkovic@wavecomp.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 4/5] hw/mips/malta: Only accept 'monitor' pflash of 4MiB
Date: Wed, 6 Mar 2019 09:01:30 +0100 [thread overview]
Message-ID: <47bf07eb-529d-eef0-3ab5-c1107e2582cf@redhat.com> (raw)
In-Reply-To: <99f44997-9abb-9e14-04c1-2a78fc76e765@linaro.org>
On 3/6/19 12:53 AM, Richard Henderson wrote:
> On 3/5/19 8:28 AM, Philippe Mathieu-Daudé wrote:
>> +
>> + if (blk_getlength(pflash_blk) != FLASH_SIZE) {
>> + error_report("Malta CoreLV card expects a bios of 4MB");
>> + exit(1);
>> + }
>
> Indentation is off, somehow. Tabs or extra spaces?
Oops... Probably extra spaces, since checkpatch didn't complain.
I'll let Markus fix this if it takes this series ;)
Thanks!
Phil.
next prev parent reply other threads:[~2019-03-06 8:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 16:28 [Qemu-devel] [PATCH 0/5] mips_malta: Clean up definition of flash memory size Philippe Mathieu-Daudé
2019-03-05 16:28 ` [Qemu-devel] [PATCH 1/5] hw/mips/malta: Fix the DEBUG_BOARD_INIT code Philippe Mathieu-Daudé
2019-03-06 13:20 ` Markus Armbruster
2019-03-07 7:06 ` Markus Armbruster
2019-03-07 13:48 ` Aleksandar Markovic
2019-03-07 13:53 ` Aleksandar Markovic
2019-03-05 16:28 ` [Qemu-devel] [PATCH 2/5] hw/mips/malta: Remove fl_sectors variable (used one single time) Philippe Mathieu-Daudé
2019-03-05 16:28 ` [Qemu-devel] [PATCH 3/5] hw/mips/malta: Restrict 'bios_size' variable scope Philippe Mathieu-Daudé
2019-03-05 16:28 ` [Qemu-devel] [PATCH 4/5] hw/mips/malta: Only accept 'monitor' pflash of 4MiB Philippe Mathieu-Daudé
2019-03-05 23:53 ` Richard Henderson
2019-03-06 8:01 ` Philippe Mathieu-Daudé [this message]
2019-03-06 13:31 ` Markus Armbruster
2019-03-05 16:28 ` [Qemu-devel] [PATCH 5/5] mips_malta: Clean up definition of flash memory size somewhat Philippe Mathieu-Daudé
2019-03-05 16:34 ` Philippe Mathieu-Daudé
2019-03-05 23:54 ` [Qemu-devel] [PATCH 0/5] mips_malta: Clean up definition of flash memory size Richard Henderson
2019-03-06 6:38 ` Aleksandar Markovic
2019-03-06 9:21 ` Philippe Mathieu-Daudé
2019-03-06 13:33 ` Markus Armbruster
2019-03-06 13:07 ` Markus Armbruster
2019-03-06 13:18 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47bf07eb-529d-eef0-3ab5-c1107e2582cf@redhat.com \
--to=philmd@redhat.com \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).