From: Akihiko Odaki <akihiko.odaki@gmail.com>
To: Yuri Benditovich <yuri.benditovich@daynix.com>,
jasowang@redhat.com, Andrew Melnychenko <andrew@daynix.com>
Cc: mst@redhat.com, armbru@redhat.com, eblake@redhat.com,
qemu-devel@nongnu.org, berrange@redhat.com, yan@daynix.com
Subject: Re: [PATCH v7 1/5] ebpf: Added eBPF map update through mmap.
Date: Mon, 11 Dec 2023 23:07:40 +0900 [thread overview]
Message-ID: <47d40dd5-3a75-4f54-91b7-2f9b073597fe@gmail.com> (raw)
In-Reply-To: <CAOEp5Od+_KHm86L7PLVo22KqLZuBc4dWjh0=4iAvT_zyhSRLMw@mail.gmail.com>
On 2023/12/11 22:48, Yuri Benditovich wrote:
> Akihiko,
> This series was already discussed several months ago.
> I'd suggest to postpone commenting on it and resume them after merging.
I found a pull request:
https://lore.kernel.org/all/20230908064507.14596-14-jasowang@redhat.com/
Strangely patches from that series seem missed although earlier patches
are on the tree. Jason, can you tell what's going on?
In any case, I wrote comments to the patch series. Andrew, can you check
them? They are mostly nitpicks, but I think you may have a look at
DEFINE_PROP_ARRAY(); it may make it easier to implement the libvirt side.
I also forgot to say that properties should not have underscores;
ebpf_rss_fds should be ebpf-rss-fds. See:
https://gitlab.com/qemu-project/qemu/-/blob/master/include/qom/object.h?ref_type=heads#L1013
The series needs to be rebased too, but probably it's better off to wait
Jason to figure out the current situation of the series. Once it gets
all sorted out, I'll rebase my series on top of it and ask for review.
Regards,
Akihiko Odaki
next prev parent reply other threads:[~2023-12-11 14:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 6:51 [PATCH v7 0/5] eBPF RSS through QMP support Andrew Melnychenko
2023-08-31 6:51 ` [PATCH v7 1/5] ebpf: Added eBPF map update through mmap Andrew Melnychenko
2023-12-11 13:05 ` Akihiko Odaki
2023-12-11 13:48 ` Yuri Benditovich
2023-12-11 14:07 ` Akihiko Odaki [this message]
2023-12-12 3:35 ` Jason Wang
2023-08-31 6:51 ` [PATCH v7 2/5] ebpf: Added eBPF initialization by fds Andrew Melnychenko
2023-12-11 13:07 ` Akihiko Odaki
2023-08-31 6:51 ` [PATCH v7 3/5] virtio-net: Added property to load eBPF RSS with fds Andrew Melnychenko
2023-12-11 13:17 ` Akihiko Odaki
2023-08-31 6:51 ` [PATCH v7 4/5] qmp: Added new command to retrieve eBPF blob Andrew Melnychenko
2023-12-11 13:30 ` Akihiko Odaki
2023-12-18 12:54 ` Markus Armbruster
2023-12-18 13:24 ` Yuri Benditovich
2023-12-18 13:32 ` Daniel P. Berrangé
2023-08-31 6:51 ` [PATCH v7 5/5] ebpf: Updated eBPF program and skeleton Andrew Melnychenko
2023-09-04 11:22 ` Andrew Melnichenko
2023-09-08 6:42 ` Jason Wang
2023-12-11 11:50 ` Yuri Benditovich
2023-12-12 3:33 ` Jason Wang
2023-12-13 7:23 ` Yuri Benditovich
2023-12-14 10:17 ` Yuri Benditovich
2023-12-18 2:48 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47d40dd5-3a75-4f54-91b7-2f9b073597fe@gmail.com \
--to=akihiko.odaki@gmail.com \
--cc=andrew@daynix.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).