* [PATCH 0/6] Fix more GCC9 -O3 warnings
@ 2019-12-17 17:32 Philippe Mathieu-Daudé
2019-12-17 17:39 ` Philippe Mathieu-Daudé
2019-12-17 21:49 ` Chubb, Peter (Data61, Kensington NSW)
0 siblings, 2 replies; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-17 17:32 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Hannes Reinecke, Gerd Hoffmann,
qemu-block, qemu-trivial, Jason Wang, Mark Cave-Ayland, Max Reitz,
Andrew Jeffery, qemu-arm, Peter Chubb, Cédric Le Goater,
Kevin Wolf, Paolo Bonzini, Philippe Mathieu-Daudé,
Joel Stanley
Fix some trivial warnings when building with -O3.
Philippe Mathieu-Daudé (6):
audio/audio: Add missing fall through comment
hw/display/tcx: Add missing fall through comments
hw/net/imx_fec: Rewrite fall through comments
hw/timer/aspeed_timer: Add a fall through comment
hw/scsi/megasas: Silent GCC9 duplicated-cond warning
qemu-io-cmds: Silent GCC9 format-overflow warning
audio/audio.c | 1 +
hw/display/tcx.c | 2 ++
hw/net/imx_fec.c | 8 +++++---
hw/scsi/megasas.c | 3 ++-
hw/timer/aspeed_timer.c | 2 +-
qemu-io-cmds.c | 1 +
6 files changed, 12 insertions(+), 5 deletions(-)
--
2.21.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
2019-12-17 17:32 [PATCH 0/6] Fix more GCC9 -O3 warnings Philippe Mathieu-Daudé
@ 2019-12-17 17:39 ` Philippe Mathieu-Daudé
2020-01-23 11:28 ` Alex Bennée
2019-12-17 21:49 ` Chubb, Peter (Data61, Kensington NSW)
1 sibling, 1 reply; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-17 17:39 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Hannes Reinecke, Gerd Hoffmann,
qemu-block, qemu-trivial, Jason Wang, Mark Cave-Ayland, Max Reitz,
Andrew Jeffery, qemu-arm, Peter Chubb, Cédric Le Goater,
Kevin Wolf, Kővágó, Zoltán, Paolo Bonzini,
Joel Stanley
On 12/17/19 6:32 PM, Philippe Mathieu-Daudé wrote:
> Fix some trivial warnings when building with -O3.
>
> Philippe Mathieu-Daudé (6):
> audio/audio: Add missing fall through comment
> hw/display/tcx: Add missing fall through comments
> hw/net/imx_fec: Rewrite fall through comments
> hw/timer/aspeed_timer: Add a fall through comment
> hw/scsi/megasas: Silent GCC9 duplicated-cond warning
> qemu-io-cmds: Silent GCC9 format-overflow warning
Sorry, this series failed because I used this tag in the first patch:
Cc: Kővágó, Zoltán <dirty.ice.hu@gmail.com>
Then git-send-email was happy with --dry-run, but then failed:
(body) Adding cc: Kővágó, Zoltán <dirty.ice.hu@gmail.com> from line 'Cc:
Kővágó, Zoltán <dirty.ice.hu@gmail.com>'
5.1.1 <K v g >: Recipient address rejected: User unknown in local
recipient table
Note to self, enclose utf-8 names, as:
Cc: "Kővágó, Zoltán" <dirty.ice.hu@gmail.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
2019-12-17 17:39 ` Philippe Mathieu-Daudé
@ 2020-01-23 11:28 ` Alex Bennée
2020-01-23 17:55 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 11+ messages in thread
From: Alex Bennée @ 2020-01-23 11:28 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Peter Maydell, Hannes Reinecke, qemu-block,
qemu-trivial, Jason Wang, Mark Cave-Ayland, qemu-devel, Max Reitz,
Joel Stanley, Andrew Jeffery, Paolo Bonzini, Peter Chubb,
Gerd Hoffmann, qemu-arm, Kővágó, Zoltán,
Kevin Wolf, Cédric Le Goater
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 12/17/19 6:32 PM, Philippe Mathieu-Daudé wrote:
>> Fix some trivial warnings when building with -O3.
>> Philippe Mathieu-Daudé (6):
>> audio/audio: Add missing fall through comment
>> hw/display/tcx: Add missing fall through comments
>> hw/net/imx_fec: Rewrite fall through comments
>> hw/timer/aspeed_timer: Add a fall through comment
>> hw/scsi/megasas: Silent GCC9 duplicated-cond warning
>> qemu-io-cmds: Silent GCC9 format-overflow warning
>
> Sorry, this series failed because I used this tag in the first patch:
>
> Cc: Kővágó, Zoltán <dirty.ice.hu@gmail.com>
>
> Then git-send-email was happy with --dry-run, but then failed:
> (body) Adding cc: Kővágó, Zoltán <dirty.ice.hu@gmail.com> from line
> 'Cc: Kővágó, Zoltán <dirty.ice.hu@gmail.com>'
> 5.1.1 <K v g >: Recipient address rejected: User unknown in local
> recipient table
>
> Note to self, enclose utf-8 names, as:
> Cc: "Kővágó, Zoltán" <dirty.ice.hu@gmail.com>
I never have to with my tags:
Cc: Alex Bennée <alex.bennee@linaro.org>
Is it possible to be more even utf-8? Sounds like a bug in the git tools
to me.
--
Alex Bennée
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
2020-01-23 11:28 ` Alex Bennée
@ 2020-01-23 17:55 ` Philippe Mathieu-Daudé
2020-01-23 18:26 ` Alex Bennée
0 siblings, 1 reply; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-23 17:55 UTC (permalink / raw)
To: Alex Bennée, Stefan Hajnoczi
Cc: Fam Zheng, Peter Maydell, Hannes Reinecke, qemu-block,
qemu-trivial, Jason Wang, Mark Cave-Ayland, qemu-devel, Max Reitz,
Joel Stanley, Andrew Jeffery, Paolo Bonzini, Peter Chubb,
Gerd Hoffmann, qemu-arm, Kővágó, Zoltán,
Kevin Wolf, Cédric Le Goater
On 1/23/20 12:28 PM, Alex Bennée wrote:
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>
>> On 12/17/19 6:32 PM, Philippe Mathieu-Daudé wrote:
>>> Fix some trivial warnings when building with -O3.
>>> Philippe Mathieu-Daudé (6):
>>> audio/audio: Add missing fall through comment
>>> hw/display/tcx: Add missing fall through comments
>>> hw/net/imx_fec: Rewrite fall through comments
>>> hw/timer/aspeed_timer: Add a fall through comment
>>> hw/scsi/megasas: Silent GCC9 duplicated-cond warning
>>> qemu-io-cmds: Silent GCC9 format-overflow warning
>>
>> Sorry, this series failed because I used this tag in the first patch:
>>
>> Cc: Kővágó, Zoltán <dirty.ice.hu@gmail.com>
>>
>> Then git-send-email was happy with --dry-run, but then failed:
>> (body) Adding cc: Kővágó, Zoltán <dirty.ice.hu@gmail.com> from line
>> 'Cc: Kővágó, Zoltán <dirty.ice.hu@gmail.com>'
>> 5.1.1 <K v g >: Recipient address rejected: User unknown in local
>> recipient table
>>
>> Note to self, enclose utf-8 names, as:
>> Cc: "Kővágó, Zoltán" <dirty.ice.hu@gmail.com>
>
> I never have to with my tags:
>
> Cc: Alex Bennée <alex.bennee@linaro.org>
>
> Is it possible to be more even utf-8? Sounds like a bug in the git tools
> to me.
The problem is the comma.
What do you mean by "more UTF-8"?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
2020-01-23 17:55 ` Philippe Mathieu-Daudé
@ 2020-01-23 18:26 ` Alex Bennée
0 siblings, 0 replies; 11+ messages in thread
From: Alex Bennée @ 2020-01-23 18:26 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Peter Maydell, Hannes Reinecke, qemu-block,
qemu-trivial, Jason Wang, Mark Cave-Ayland, qemu-devel, Max Reitz,
Joel Stanley, Andrew Jeffery, Paolo Bonzini, Peter Chubb,
Gerd Hoffmann, Stefan Hajnoczi,
Kővágó, Zoltán, Kevin Wolf, qemu-arm,
Cédric Le Goater
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 1/23/20 12:28 PM, Alex Bennée wrote:
>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>
>>> On 12/17/19 6:32 PM, Philippe Mathieu-Daudé wrote:
>>>> Fix some trivial warnings when building with -O3.
>>>> Philippe Mathieu-Daudé (6):
>>>> audio/audio: Add missing fall through comment
>>>> hw/display/tcx: Add missing fall through comments
>>>> hw/net/imx_fec: Rewrite fall through comments
>>>> hw/timer/aspeed_timer: Add a fall through comment
>>>> hw/scsi/megasas: Silent GCC9 duplicated-cond warning
>>>> qemu-io-cmds: Silent GCC9 format-overflow warning
>>>
>>> Sorry, this series failed because I used this tag in the first patch:
>>>
>>> Cc: Kővágó, Zoltán <dirty.ice.hu@gmail.com>
>>>
>>> Then git-send-email was happy with --dry-run, but then failed:
>>> (body) Adding cc: Kővágó, Zoltán <dirty.ice.hu@gmail.com> from line
>>> 'Cc: Kővágó, Zoltán <dirty.ice.hu@gmail.com>'
>>> 5.1.1 <K v g >: Recipient address rejected: User unknown in local
>>> recipient table
>>>
>>> Note to self, enclose utf-8 names, as:
>>> Cc: "Kővágó, Zoltán" <dirty.ice.hu@gmail.com>
>> I never have to with my tags:
>> Cc: Alex Bennée <alex.bennee@linaro.org>
>> Is it possible to be more even utf-8? Sounds like a bug in the git
>> tools
>> to me.
>
> The problem is the comma.
> What do you mean by "more UTF-8"?
It was a joke - I think you are either utf-8 clean or not. Now the
question is should the tools have slurped the coma as part of the name?
Is it a localisation issue?
--
Alex Bennée
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
2019-12-17 17:32 [PATCH 0/6] Fix more GCC9 -O3 warnings Philippe Mathieu-Daudé
2019-12-17 17:39 ` Philippe Mathieu-Daudé
@ 2019-12-17 21:49 ` Chubb, Peter (Data61, Kensington NSW)
2019-12-18 6:05 ` Markus Armbruster
1 sibling, 1 reply; 11+ messages in thread
From: Chubb, Peter (Data61, Kensington NSW) @ 2019-12-17 21:49 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Peter Maydell, Hannes Reinecke, Gerd Hoffmann,
qemu-block@nongnu.org, qemu-trivial@nongnu.org, Jason Wang,
Mark Cave-Ayland, qemu-devel@nongnu.org, Max Reitz,
Andrew Jeffery, qemu-arm@nongnu.org, Peter Chubb,
Cédric Le Goater, Kevin Wolf, Paolo Bonzini, Joel Stanley
>>>>> "Philippe" == Philippe Mathieu-Daudé <philmd@redhat.com> writes:
Philippe> Fix some trivial warnings when building with -O3.
For compatibility with lint and other older checkers, it'd be good to keep
this as /* FALLTHROUGH */ (which gcc should accept according to its
manual).
Fixing the comments' placement is a different matter, and should be
done. Seems to me that until gcc started warning for this, noone had
actually run a checker, and the comments were just for human info.
Peter C
--
Dr Peter Chubb Tel: +61 2 9490 5852 http://ts.data61.csiro.au/
Trustworthy Systems Group Data61 (formerly NICTA)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
2019-12-17 21:49 ` Chubb, Peter (Data61, Kensington NSW)
@ 2019-12-18 6:05 ` Markus Armbruster
2020-01-18 19:24 ` Paolo Bonzini
0 siblings, 1 reply; 11+ messages in thread
From: Markus Armbruster @ 2019-12-18 6:05 UTC (permalink / raw)
To: Chubb, Peter (Data61, Kensington NSW)
Cc: Fam Zheng, Peter Maydell, Hannes Reinecke, qemu-block@nongnu.org,
qemu-trivial@nongnu.org, Jason Wang, Mark Cave-Ayland,
qemu-devel@nongnu.org, Max Reitz, Joel Stanley, Andrew Jeffery,
qemu-arm@nongnu.org, Peter Chubb, Gerd Hoffmann, Paolo Bonzini,
Kevin Wolf, Philippe Mathieu-Daudé, Cédric Le Goater
"Chubb, Peter (Data61, Kensington NSW)" <Peter.Chubb@data61.csiro.au>
writes:
>>>>>> "Philippe" == Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>
> Philippe> Fix some trivial warnings when building with -O3.
>
> For compatibility with lint and other older checkers, it'd be good to keep
> this as /* FALLTHROUGH */ (which gcc should accept according to its
> manual).
We have hundreds of /* fall through */ comments already.
> Fixing the comments' placement is a different matter, and should be
> done. Seems to me that until gcc started warning for this, noone had
> actually run a checker, and the comments were just for human info.
>
> Peter C
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
2019-12-18 6:05 ` Markus Armbruster
@ 2020-01-18 19:24 ` Paolo Bonzini
2020-01-20 19:02 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 11+ messages in thread
From: Paolo Bonzini @ 2020-01-18 19:24 UTC (permalink / raw)
To: Markus Armbruster, Chubb, Peter (Data61, Kensington NSW)
Cc: Fam Zheng, Peter Maydell, Hannes Reinecke, qemu-block@nongnu.org,
qemu-trivial@nongnu.org, Jason Wang, Mark Cave-Ayland,
qemu-devel@nongnu.org, Max Reitz, Joel Stanley, Andrew Jeffery,
qemu-arm@nongnu.org, Peter Chubb, Gerd Hoffmann, Kevin Wolf,
Philippe Mathieu-Daudé, Cédric Le Goater
On 18/12/19 07:05, Markus Armbruster wrote:
> "Chubb, Peter (Data61, Kensington NSW)" <Peter.Chubb@data61.csiro.au>
> writes:
>
>>>>>>> "Philippe" == Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>
>> Philippe> Fix some trivial warnings when building with -O3.
>>
>> For compatibility with lint and other older checkers, it'd be good to keep
>> this as /* FALLTHROUGH */ (which gcc should accept according to its
>> manual).
>
> We have hundreds of /* fall through */ comments already.
>
>> Fixing the comments' placement is a different matter, and should be
>> done. Seems to me that until gcc started warning for this, noone had
>> actually run a checker, and the comments were just for human info.
>>
>> Peter C
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
2020-01-18 19:24 ` Paolo Bonzini
@ 2020-01-20 19:02 ` Philippe Mathieu-Daudé
2020-01-21 10:49 ` Paolo Bonzini
0 siblings, 1 reply; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-20 19:02 UTC (permalink / raw)
To: Paolo Bonzini, Markus Armbruster,
Chubb, Peter (Data61, Kensington NSW)
Cc: Fam Zheng, Peter Maydell, Hannes Reinecke, qemu-block@nongnu.org,
qemu-trivial@nongnu.org, Jason Wang, Mark Cave-Ayland,
qemu-devel@nongnu.org, Max Reitz, Joel Stanley, Andrew Jeffery,
qemu-arm@nongnu.org, Peter Chubb, Gerd Hoffmann, Kevin Wolf,
Cédric Le Goater
Hi Paolo,
On 1/18/20 8:24 PM, Paolo Bonzini wrote:
> On 18/12/19 07:05, Markus Armbruster wrote:
>> "Chubb, Peter (Data61, Kensington NSW)" <Peter.Chubb@data61.csiro.au>
>> writes:
>>
>>>>>>>> "Philippe" == Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>>
>>> Philippe> Fix some trivial warnings when building with -O3.
>>>
>>> For compatibility with lint and other older checkers, it'd be good to keep
>>> this as /* FALLTHROUGH */ (which gcc should accept according to its
>>> manual).
>>
>> We have hundreds of /* fall through */ comments already.
>>
>>> Fixing the comments' placement is a different matter, and should be
>>> done. Seems to me that until gcc started warning for this, noone had
>>> actually run a checker, and the comments were just for human info.
>>>
>>> Peter C
>>
>
> Queued, thanks.
Thanks, but I sent a v2 (20191218192526.13845-1-philmd@redhat.com) with:
- addressed Thomas and Aleksandar comments
- dropped 'hw/scsi/megasas: Silent GCC9 duplicated-cond warning'
- dropped 'qemu-io-cmds: Silent GCC9 format-overflow warning'
See:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg666280.html
Can you queue it instead?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
2020-01-20 19:02 ` Philippe Mathieu-Daudé
@ 2020-01-21 10:49 ` Paolo Bonzini
0 siblings, 0 replies; 11+ messages in thread
From: Paolo Bonzini @ 2020-01-21 10:49 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Markus Armbruster,
Chubb, Peter (Data61, Kensington NSW)
Cc: Fam Zheng, Peter Maydell, Hannes Reinecke, qemu-block@nongnu.org,
qemu-trivial@nongnu.org, Jason Wang, Mark Cave-Ayland,
qemu-devel@nongnu.org, Max Reitz, Joel Stanley, Andrew Jeffery,
qemu-arm@nongnu.org, Peter Chubb, Gerd Hoffmann, Kevin Wolf,
Cédric Le Goater
On 20/01/20 20:02, Philippe Mathieu-Daudé wrote:
> Hi Paolo,
>
> On 1/18/20 8:24 PM, Paolo Bonzini wrote:
>> On 18/12/19 07:05, Markus Armbruster wrote:
>>> "Chubb, Peter (Data61, Kensington NSW)" <Peter.Chubb@data61.csiro.au>
>>> writes:
>>>
>>>>>>>>> "Philippe" == Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>>>
>>>> Philippe> Fix some trivial warnings when building with -O3.
>>>>
>>>> For compatibility with lint and other older checkers, it'd be good
>>>> to keep
>>>> this as /* FALLTHROUGH */ (which gcc should accept according to its
>>>> manual).
>>>
>>> We have hundreds of /* fall through */ comments already.
>>>
>>>> Fixing the comments' placement is a different matter, and should be
>>>> done. Seems to me that until gcc started warning for this, noone had
>>>> actually run a checker, and the comments were just for human info.
>>>>
>>>> Peter C
>>>
>>
>> Queued, thanks.
>
> Thanks, but I sent a v2 (20191218192526.13845-1-philmd@redhat.com) with:
>
> - addressed Thomas and Aleksandar comments
> - dropped 'hw/scsi/megasas: Silent GCC9 duplicated-cond warning'
> - dropped 'qemu-io-cmds: Silent GCC9 format-overflow warning'
>
> See:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg666280.html
>
> Can you queue it instead?
Yes, I replaced it.
Paolo
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 0/6] Fix more GCC9 -O3 warnings
@ 2019-12-17 17:34 Philippe Mathieu-Daudé
0 siblings, 0 replies; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-17 17:34 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Hannes Reinecke, Gerd Hoffmann,
qemu-block, qemu-trivial, Jason Wang, Mark Cave-Ayland, Max Reitz,
Andrew Jeffery, qemu-arm, Peter Chubb, Cédric Le Goater,
Kevin Wolf, Kővágó, Zoltán, Paolo Bonzini,
Philippe Mathieu-Daudé, Joel Stanley
Fix some trivial warnings when building with -O3.
Philippe Mathieu-Daudé (6):
audio/audio: Add missing fall through comment
hw/display/tcx: Add missing fall through comments
hw/net/imx_fec: Rewrite fall through comments
hw/timer/aspeed_timer: Add a fall through comment
hw/scsi/megasas: Silent GCC9 duplicated-cond warning
qemu-io-cmds: Silent GCC9 format-overflow warning
audio/audio.c | 1 +
hw/display/tcx.c | 2 ++
hw/net/imx_fec.c | 8 +++++---
hw/scsi/megasas.c | 3 ++-
hw/timer/aspeed_timer.c | 2 +-
qemu-io-cmds.c | 1 +
6 files changed, 12 insertions(+), 5 deletions(-)
--
2.21.0
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-01-23 20:03 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-17 17:32 [PATCH 0/6] Fix more GCC9 -O3 warnings Philippe Mathieu-Daudé
2019-12-17 17:39 ` Philippe Mathieu-Daudé
2020-01-23 11:28 ` Alex Bennée
2020-01-23 17:55 ` Philippe Mathieu-Daudé
2020-01-23 18:26 ` Alex Bennée
2019-12-17 21:49 ` Chubb, Peter (Data61, Kensington NSW)
2019-12-18 6:05 ` Markus Armbruster
2020-01-18 19:24 ` Paolo Bonzini
2020-01-20 19:02 ` Philippe Mathieu-Daudé
2020-01-21 10:49 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2019-12-17 17:34 Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).