From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0EA1C6FA99 for ; Wed, 8 Mar 2023 01:21:35 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZiNc-00043K-Jb; Tue, 07 Mar 2023 20:14:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZiNb-00041v-02 for qemu-devel@nongnu.org; Tue, 07 Mar 2023 20:14:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZiNZ-00020K-EX for qemu-devel@nongnu.org; Tue, 07 Mar 2023 20:14:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678238044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8u+wqiyIGWdIFx3L2uxAk2b2QIaEfOdTnlLdNSylGZw=; b=jA7S6V3YrBIBDsn6DqVStvOBiHKelu5qzOlwNUXtEkczZeprfwy0vv1mUL80k0TCtCogTt iuWUqX1pRhb+VAB9fGwVuLyOKxSF2IMUbs0D0KSaIbkF3UoNxGYKYk2R1jjyWVwnP9NWi9 Cxf0mwzMOv38EOJc/l2eJxB00Iw+eZA= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-LeaHc68hNqyXiDAWqWsoIA-1; Tue, 07 Mar 2023 20:14:03 -0500 X-MC-Unique: LeaHc68hNqyXiDAWqWsoIA-1 Received: by mail-ed1-f72.google.com with SMTP id y24-20020aa7ccd8000000b004be3955a42eso21658562edt.22 for ; Tue, 07 Mar 2023 17:14:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678238042; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8u+wqiyIGWdIFx3L2uxAk2b2QIaEfOdTnlLdNSylGZw=; b=1Uh07dp0ohD2oG3S/XYpRoycBukiVnU57DM40hBgfzZEVsF8OO6CCxEYrzhLU95ODh +CRgybqp7Exoc6mjGLwn8kgHCZ+8qF38G0J4f5aNzmUqYY7+e0STcjy8SiDrw1eMFfMI zjq9wUj1EjYeHNxn1jgB+ilSeCJKBz5x5Vzk+7CL6AxMUnCRt/xI/g6SF57V8ct/3erD SIXsMCuEUUGCJNRak0DgxDi/GbEXn2CGH1VFIu1tKbqlz2JiqsP84EKXYMAkTmr8Is+q 1nIwMo3zol8D0kSvxncwUJP7KP+XSCYv4xq99xaAoY/jd49QwM/qRM3a/emF0I6LPMja IccA== X-Gm-Message-State: AO0yUKVMTeXXxFWCr2s5DeG6ubt2N7fe108zhNgjTR+1XLXJU85ZL6bs hezubsSb7lQqHCE3TtCuWhH6PfXfj3Fx9oGpfUzOxJnAVg+nDxV35gARZIvHiChknIhPyNvvCDB I5fcWn6aqjWJUDk3XeF7K+m7aEXUAvLTObMxYWgJlkXwQJsA2VC9CpVF2FzvfhqFdCQeQ X-Received: by 2002:a05:6402:6cc:b0:4af:62ad:1571 with SMTP id n12-20020a05640206cc00b004af62ad1571mr15810123edy.23.1678238041874; Tue, 07 Mar 2023 17:14:01 -0800 (PST) X-Google-Smtp-Source: AK7set9ZKCvuN5NUs64AJvyaIVuBJyGIfF0kxuQYmYcWTsyBIEPiMCjp4PRvN0gEPLNNMGKfjZZrFw== X-Received: by 2002:a05:6402:6cc:b0:4af:62ad:1571 with SMTP id n12-20020a05640206cc00b004af62ad1571mr15810112edy.23.1678238041645; Tue, 07 Mar 2023 17:14:01 -0800 (PST) Received: from redhat.com ([2.52.138.216]) by smtp.gmail.com with ESMTPSA id s22-20020a50ab16000000b004f238d1ad8asm250171edc.38.2023.03.07.17.14.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 17:14:01 -0800 (PST) Date: Tue, 7 Mar 2023 20:13:58 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Jonathan Cameron , Dave Jiang , Fan Ni , Marcel Apfelbaum Subject: [PULL 63/73] hw/pci-bridge/cxl_root_port: Wire up AER Message-ID: <47f0e7ab3272737c174ca68c03843e0d1996dc22.1678237635.git.mst@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Jonathan Cameron We are missing necessary config write handling for AER emulation in the CXL root port. Add it based on pcie_root_port.c Signed-off-by: Jonathan Cameron Reviewed-by: Dave Jiang Message-Id: <20230302133709.30373-4-Jonathan.Cameron@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Fan Ni --- hw/pci-bridge/cxl_root_port.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/pci-bridge/cxl_root_port.c b/hw/pci-bridge/cxl_root_port.c index 6664783974..00195257f7 100644 --- a/hw/pci-bridge/cxl_root_port.c +++ b/hw/pci-bridge/cxl_root_port.c @@ -187,12 +187,15 @@ static void cxl_rp_write_config(PCIDevice *d, uint32_t address, uint32_t val, int len) { uint16_t slt_ctl, slt_sta; + uint32_t root_cmd = + pci_get_long(d->config + d->exp.aer_cap + PCI_ERR_ROOT_COMMAND); pcie_cap_slot_get(d, &slt_ctl, &slt_sta); pci_bridge_write_config(d, address, val, len); pcie_cap_flr_write_config(d, address, val, len); pcie_cap_slot_write_config(d, slt_ctl, slt_sta, address, val, len); pcie_aer_write_config(d, address, val, len); + pcie_aer_root_write_config(d, address, val, len, root_cmd); cxl_rp_dvsec_write_config(d, address, val, len); } -- MST