From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: "Philippe Mathieu-Daudé " <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Volker Rü melin" <vr_qemu@t-online.de>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [PATCH-for-8.2] virtio-sound: add realize() error cleanup path
Date: Thu, 16 Nov 2023 10:48:13 +0200 [thread overview]
Message-ID: <47klp.p79qnee6q9fx@linaro.org> (raw)
In-Reply-To: <688bc783-e56f-4e24-95f6-a69aa4bc8863@linaro.org>
On Thu, 16 Nov 2023 10:42, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>On 16/11/23 08:33, Manos Pitsidianakis wrote:
>> On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé <philmd@linaro.org>
>> wrote:
>>>> ---
>>>>
>>>> Notes:
>>>> Requires patch
>>>> <20231109162034.2108018-1-manos.pitsidianakis@linaro.org>
>>>
>>> This is the 'Based-on: ' tag I guess.
>>
>> There is
>>
>> prerequisite-patch-id: 484ec9f7f6109c10d4be0484fe8e3c2550c415f4
>
>$ git show 484ec9f7f6109c10d4be0484fe8e3c2550c415f4
>fatal: bad object 484ec9f7f6109c10d4be0484fe8e3c2550c415f4
>
>In which tree can we find this commit? Better to use the msg-id,
>so tools cat fetch prerequisite.
>
>I guess the 'patches' tool understand 'Based-on'. Or was it 'patchew'?
It's not a commit SHA, that's why. It's a sha produced by git-patch-id
--stable. It hashes the diffs of the plain-text patch.
https://git-scm.com/docs/git-patch-id
Yes, whatever works with current tools is best!
Manos
next prev parent reply other threads:[~2023-11-16 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 7:20 [PATCH-for-8.2] virtio-sound: add realize() error cleanup path Manos Pitsidianakis
2023-11-16 7:32 ` Philippe Mathieu-Daudé
2023-11-16 7:33 ` Manos Pitsidianakis
2023-11-16 8:42 ` Philippe Mathieu-Daudé
2023-11-16 8:48 ` Manos Pitsidianakis [this message]
2023-11-16 8:54 ` Philippe Mathieu-Daudé
2023-11-16 9:16 ` Manos Pitsidianakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47klp.p79qnee6q9fx@linaro.org \
--to=manos.pitsidianakis@linaro.org \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).