From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JlRRP-0005Y7-4e for qemu-devel@nongnu.org; Mon, 14 Apr 2008 12:21:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JlRRN-0005Vq-Ll for qemu-devel@nongnu.org; Mon, 14 Apr 2008 12:21:58 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JlRRN-0005VX-9y for qemu-devel@nongnu.org; Mon, 14 Apr 2008 12:21:57 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JlRRM-0004oS-CR for qemu-devel@nongnu.org; Mon, 14 Apr 2008 12:21:57 -0400 Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216]) by fmmailgate03.web.de (Postfix) with ESMTP id 30ACBD70E6F7 for ; Mon, 14 Apr 2008 18:21:53 +0200 (CEST) Received: from [88.64.24.193] (helo=[139.25.109.167]) by smtp08.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1JlRRI-0000w7-00 for qemu-devel@nongnu.org; Mon, 14 Apr 2008 18:21:52 +0200 Message-ID: <4803849F.2030609@web.de> Date: Mon, 14 Apr 2008 18:21:51 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4801DC59.1010403@web.de> <480300D2.2060400@web.de> <20080414131209.GA4420@miranda.arrow> In-Reply-To: <20080414131209.GA4420@miranda.arrow> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig85B6C366309CF4531FFEC0C9" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [RFC][PATCH 4/4] Add support for Marvell 88w8618 / MusicPal Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig85B6C366309CF4531FFEC0C9 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Stuart Brady wrote: > On Mon, Apr 14, 2008 at 08:59:30AM +0200, Jan Kiszka wrote: >> malc wrote: >>> Zero is not correct "mute" value for signed formats. >> Hmm, maybe it's still too early for me - but what else?? >=20 > Well, zero is not correct for unsigned formats, but I cannot see any > such formats in use in your emulation... /me too. > BTW, there are quite a few magic constants that it would probably be > better to #define. I know. Comes a bit from the initial approach: "Hey, let's see how far this hack will get." Will try to fix those spots where possible. Jan --------------enig85B6C366309CF4531FFEC0C9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFIA4SgniDOoMHTA+kRAtWwAJ4nokThxLtzr1A+oz8OOsn2eWEGhgCfQcHY qM8kV5+iBh1E7BbTFR8K60A= =oH/R -----END PGP SIGNATURE----- --------------enig85B6C366309CF4531FFEC0C9--