From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JlUFu-0001jw-UZ
	for qemu-devel@nongnu.org; Mon, 14 Apr 2008 15:22:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JlUFq-0001iL-BB
	for qemu-devel@nongnu.org; Mon, 14 Apr 2008 15:22:18 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JlUFq-0001iE-1F
	for qemu-devel@nongnu.org; Mon, 14 Apr 2008 15:22:14 -0400
Received: from fmmailgate01.web.de ([217.72.192.221])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1JlUFp-0001Pb-Bu
	for qemu-devel@nongnu.org; Mon, 14 Apr 2008 15:22:13 -0400
Received: from smtp05.web.de (fmsmtp05.dlan.cinetic.de [172.20.4.166])
	by fmmailgate01.web.de (Postfix) with ESMTP id 0DD7EDB4A8F0
	for <qemu-devel@nongnu.org>; Mon, 14 Apr 2008 21:22:02 +0200 (CEST)
Received: from [88.64.24.193] (helo=[192.168.1.198])
	by smtp05.web.de with asmtp (TLSv1:AES256-SHA:256)
	(WEB.DE 4.109 #226) id 1JlUFd-0006F2-00
	for qemu-devel@nongnu.org; Mon, 14 Apr 2008 21:22:01 +0200
Message-ID: <4803AED9.7010001@web.de>
Date: Mon, 14 Apr 2008 21:22:01 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4801C476.3040509@web.de>
	<fb249edb0804141137i3498a131lecee74ab28127fc3@mail.gmail.com>
In-Reply-To: <fb249edb0804141137i3498a131lecee74ab28127fc3@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig226B1EFE17F0650DCFD8E354"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH 2/2] 8250: Customized base baudrate
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig226B1EFE17F0650DCFD8E354
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

andrzej zaborowski wrote:
> On 13/04/2008, Jan Kiszka <jan.kiszka@web.de> wrote:
>>  --- a/hw/omap1.c
>>  +++ b/hw/omap1.c
>>  @@ -1734,7 +1734,8 @@ struct omap_uart_s *omap_uart_init(targe
>>      struct omap_uart_s *s =3D (struct omap_uart_s *)
>>              qemu_mallocz(sizeof(struct omap_uart_s));
>>      if (chr)
>>  -        s->serial =3D serial_mm_init(base, 2, irq, chr, 1);
>>  +        s->serial =3D
>>  +            serial_mm_init(base, 2, irq, omap_clk_getrate(clk)/16, c=
hr, 1);
>=20
> Yes, this should be correct.

While typing those line I wondered if it is possible and reasonable that
a guest changes this clock rate during runtime? In that case, the
perfect, but probably much more complex solution would be to track those
changes also with the serial emulation...

Jan


--------------enig226B1EFE17F0650DCFD8E354
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFIA67ZniDOoMHTA+kRAq3IAJoDLvVAhmG2m6eo2oqFrWu9KHAiWwCfY95L
uol6BclwmWQKQgovrhqX1Z8=
=RXYu
-----END PGP SIGNATURE-----

--------------enig226B1EFE17F0650DCFD8E354--