From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Jm3Dq-0001UX-0z
	for qemu-devel@nongnu.org; Wed, 16 Apr 2008 04:42:30 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Jm3Do-0001Tu-JA
	for qemu-devel@nongnu.org; Wed, 16 Apr 2008 04:42:29 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Jm3Do-0001TW-C9
	for qemu-devel@nongnu.org; Wed, 16 Apr 2008 04:42:28 -0400
Received: from cantor2.suse.de ([195.135.220.15] helo=mx2.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <kwolf@suse.de>) id 1Jm3Dk-0008E1-4O
	for qemu-devel@nongnu.org; Wed, 16 Apr 2008 04:42:24 -0400
Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx2.suse.de (Postfix) with ESMTP id 5873745036
	for <qemu-devel@nongnu.org>; Wed, 16 Apr 2008 10:42:22 +0200 (CEST)
Message-ID: <4805BAB0.1030707@suse.de>
Date: Wed, 16 Apr 2008 10:37:04 +0200
From: Kevin Wolf <kwolf@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] Reboot CPU on triple fault
References: <47EE86E0.4070703@reactos.org>
	<47F0B445.4030806@suse.de>	<4804D254.5040301@siemens.com>
	<200804151757.05303.paul@codesourcery.com>
In-Reply-To: <200804151757.05303.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Paul Brook schrieb:
>> +    if (env->old_exception == EXCP08_DBLE) {
>> +        fprintf(stderr, "qemu: warning: triple fault\n");
> 
> IMHO There's no reason to print a message to stderr. This is all well defined 
> behavior, and the accepted way of exiting from 286 protected mode.

How many users does qemu have who need triple faults to exit from 286
Protected Mode? And how many users does it have who don't use triple
faults (yes, it's called a fault, not a PM exiting feature)
intentionally but might want the message and dumps for debugging?
Personally I suspect that a great majority belongs to the latter case.

And honestly, a message on stderr really shouldn't hurt those 286 folks.
They are even getting the reset they want from this patch.

Kevin