From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JmQmz-0008NF-Qo
	for qemu-devel@nongnu.org; Thu, 17 Apr 2008 05:52:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JmQmy-0008Md-V5
	for qemu-devel@nongnu.org; Thu, 17 Apr 2008 05:52:21 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JmQmy-0008MZ-Rc
	for qemu-devel@nongnu.org; Thu, 17 Apr 2008 05:52:20 -0400
Received: from gecko.sbs.de ([194.138.37.40])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1JmQmy-0002JN-55
	for qemu-devel@nongnu.org; Thu, 17 Apr 2008 05:52:20 -0400
Received: from mail1.sbs.de (localhost [127.0.0.1])
	by gecko.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id m3H9qH54013613
	for <qemu-devel@nongnu.org>; Thu, 17 Apr 2008 11:52:17 +0200
Received: from [139.21.95.227] (mchn012c.mchh.siemens.de [139.21.95.227] (may
	be forged))
	by mail1.sbs.de (8.12.6/8.12.6) with ESMTP id m3H9qGoJ012920
	for <qemu-devel@nongnu.org>; Thu, 17 Apr 2008 11:52:17 +0200
Message-ID: <48071DD0.8020203@siemens.com>
Date: Thu, 17 Apr 2008 11:52:16 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <47EE86E0.4070703@reactos.org>	<9C7667CB-2CF0-4AC0-843B-6EF442196CAC@csgraf.de>	<47F0B445.4030806@suse.de>	<4804D254.5040301@siemens.com>	<4805F4B0.5020802@siemens.com>	<4806009E.8060407@suse.de>	<48060ACC.2020309@siemens.com>	<48060E28.7000606@suse.de>
	<480613D3.3080509@suse.de>
In-Reply-To: <480613D3.3080509@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] x86: Reboot CPU on triple fault - Version 6
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Kevin Wolf wrote:
> Quite a few rounds for such a short patch. But surely a CPU dump without
> any explanation isn't optimal. We should put a "CPU Reset" line in the
> log before the dump.
> 
> Signed-off-by: Kevin Wolf <kwolf@suse.de>
> 

Acked-by: Jan Kiszka <jan.kiszka@siemens.com>

(But you should kill the trailing whitespace in helper2.c - quilt can
helpful for managing patches and keeping such things clean.)

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux