From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JmZR9-0001I6-Qh for qemu-devel@nongnu.org; Thu, 17 Apr 2008 15:06:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JmZR8-0001Fl-Ck for qemu-devel@nongnu.org; Thu, 17 Apr 2008 15:06:23 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmZR8-0001FL-45 for qemu-devel@nongnu.org; Thu, 17 Apr 2008 15:06:22 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JmZR7-0006v2-GY for qemu-devel@nongnu.org; Thu, 17 Apr 2008 15:06:21 -0400 Received: from smtp06.web.de (fmsmtp06.dlan.cinetic.de [172.20.5.172]) by fmmailgate03.web.de (Postfix) with ESMTP id 0B945D7726B1 for ; Thu, 17 Apr 2008 21:06:20 +0200 (CEST) Received: from [88.64.31.1] (helo=[192.168.1.198]) by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1JmZR5-0003WY-00 for qemu-devel@nongnu.org; Thu, 17 Apr 2008 21:06:19 +0200 Message-ID: <48079FA6.3080104@web.de> Date: Thu, 17 Apr 2008 21:06:14 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4801DC59.1010403@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig1A652B14D9D861D21568BC36" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [RFC][PATCH 4/4] Add support for Marvell 88w8618 / MusicPal Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1A652B14D9D861D21568BC36 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable andrzej zaborowski wrote: > Hi, >=20 > On 13/04/2008, Jan Kiszka wrote: >> This is the board emulation for Freecom's MusicPal, featuring >> - rudimentary PIT and PIC >> - up to 2 UARTs >> - 88W8xx8 Ethernet controller >> - 88W8618 audio controller >> - Wolfson WM8750 mixer chip (volume control and mute only) >=20 > Are you sure that hw/wm8750.c is not reusable? It's probably better > to extend it with volume control, and audio data transmission through > i2c, instead of having two implementations in QEMU. Will check again, but I don't think it is helpful, at least at this point. The thing is that the MusicPal uses the on-chip DAC, not the one of the Wolfson. The latter seems to be responsible for analogous mixing only. >=20 > Regarding volume control, since there are only 0x7f possible values > it's nicer to use a const table than pull in math.h. Actually I > wouldn't worry about that at all because the layout of volume levels > on the host is not guaranteed to be linear (I think?), it may very > well be already exponential. For example the Linux WM8750 driver > doesn't do the reverse transformation which would mean that on a host > whose ALSA output device is a WM8750, the Qemu vm would have a wrong > volume scale. [ Ignoring the above as advised in the follow-up, but will think about avoiding or reducing the usage of pow(). ] >=20 >> - 128=C3=9764 display with brightness control >> - all input buttons >> >> Using up to 32 MB flash, I hit a limit /wrt phys_ram_size. I worked >> around this for now by extending MAX_BIOS_SIZE to 32 MB, surely not a= >> nice solution. >=20 > You can use -m 150 or similar. >=20 > Please also format the code similarly to rest of Qemu. That would just increase ram_size, thus won't help as I need memory beyond it (here for the pflash in R/W mode). Jan --------------enig1A652B14D9D861D21568BC36 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFIB5+qniDOoMHTA+kRAv75AJ4jC1N54NlHXgANnIdGSnu6zbRcFQCfTeF4 m4+XUwVSzLqG1NRBr2PZL1E= =MGUo -----END PGP SIGNATURE----- --------------enig1A652B14D9D861D21568BC36--