From: Kevin Wolf <kwolf@suse.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] x86: Reboot CPU on triple fault - Version 4
Date: Fri, 18 Apr 2008 10:38:27 +0200 [thread overview]
Message-ID: <48085E03.5040708@suse.de> (raw)
In-Reply-To: <4807972C.8030807@codemonkey.ws>
Anthony Liguori schrieb:
> It's not a question of whether it's logged, it's a question of whether
> it gets logged *specially*. That's the crux of the discussion here. My
> argument is that triple faults are not sufficiently special that they
> warrant *special* logging.
I think CPU resets are special enough indeed. Obviously there _are_ use
cases for this option and nobody who doesn't turn it on intentionally
could ever get hurt by it. So what is your problem with it?
Honestly, it is ridiculous that we keep arguing about log messages while
the main thing changed by the patch is the introduction of the correct
CPU reset. I suspect we would never have discussed all these loglevel
things if the latest patch wouldn't have been submitted as answer on a
(not even working) patch which tried to remove the log...
Kevin
next prev parent reply other threads:[~2008-04-18 9:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 18:13 [Qemu-devel] [PATCH] Reboot CPU on triple fault Hervé Poussineau
2008-03-30 1:36 ` Alexander Graf
2008-03-31 9:52 ` Kevin Wolf
2008-04-15 16:05 ` [Qemu-devel] " Jan Kiszka
2008-04-15 16:57 ` Paul Brook
2008-04-16 8:37 ` Kevin Wolf
2008-04-16 9:23 ` Jamie Lokier
2008-04-16 9:51 ` Antoine Kaufmann
2008-04-16 9:53 ` Kevin Wolf
2008-04-16 10:17 ` Michal Schulz
2008-04-16 10:25 ` Michal Schulz
2008-04-16 12:08 ` Kevin Wolf
2008-04-16 10:22 ` Jan Kiszka
2008-04-16 11:34 ` Jamie Lokier
2008-04-16 14:44 ` Anthony Liguori
2008-04-16 8:18 ` Kevin Wolf
2008-04-16 12:02 ` Jan Kiszka
2008-04-16 12:09 ` Avi Kivity
2008-04-16 12:36 ` Kevin Wolf
2008-04-16 12:57 ` Jamie Lokier
2008-04-16 12:44 ` [Qemu-devel] [PATCH] x86: Reboot CPU on triple fault - Version 3 Jan Kiszka
2008-04-16 13:35 ` [Qemu-devel] [PATCH] x86: Reboot CPU on triple fault - Version 4 Kevin Wolf
2008-04-16 14:18 ` [Qemu-devel] " Jan Kiszka
2008-04-16 14:33 ` [Qemu-devel] [PATCH] x86: Reboot CPU on triple fault - Version 5 Kevin Wolf
2008-04-16 14:57 ` [Qemu-devel] [PATCH] x86: Reboot CPU on triple fault - Version 6 Kevin Wolf
2008-04-17 9:52 ` [Qemu-devel] " Jan Kiszka
2008-04-18 14:06 ` [Qemu-devel] " Anthony Liguori
2008-04-21 11:53 ` Kevin Wolf
2008-05-26 14:46 ` [Qemu-devel] " Jan Kiszka
2008-05-27 16:01 ` [Qemu-devel] [PATCH] x86: Reboot CPU on triple fault - Version 8 Jan Kiszka
2008-05-27 16:17 ` [Qemu-devel] " Jan Kiszka
2008-04-16 14:37 ` [Qemu-devel] Re: [PATCH] x86: Reboot CPU on triple fault - Version 4 Anthony Liguori
2008-04-17 8:07 ` Jan Kiszka
2008-04-17 12:49 ` Anthony Liguori
2008-04-17 14:10 ` Jan Kiszka
2008-04-17 18:30 ` Anthony Liguori
2008-04-17 19:24 ` Jan Kiszka
2008-04-18 8:38 ` Kevin Wolf [this message]
2008-04-18 14:08 ` Anthony Liguori
2008-04-21 9:37 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48085E03.5040708@suse.de \
--to=kwolf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).