From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JnhbR-00050f-Ig
	for qemu-devel@nongnu.org; Sun, 20 Apr 2008 18:01:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JnhbO-00050T-3k
	for qemu-devel@nongnu.org; Sun, 20 Apr 2008 18:01:41 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JnhbO-00050Q-17
	for qemu-devel@nongnu.org; Sun, 20 Apr 2008 18:01:38 -0400
Received: from hs-out-0708.google.com ([64.233.178.246])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1JnhbO-0006xH-2M
	for qemu-devel@nongnu.org; Sun, 20 Apr 2008 18:01:38 -0400
Received: by hs-out-0708.google.com with SMTP id k27so698748hsc.2
	for <qemu-devel@nongnu.org>; Sun, 20 Apr 2008 15:01:36 -0700 (PDT)
Message-ID: <480BBD37.5010409@codemonkey.ws>
Date: Sun, 20 Apr 2008 17:01:27 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add -display option
References: <BAY110-DAV84E68554126EF6FD13300B9E90@phx.gbl><027a01c89e6f$a103d300$0201a8c0@zeug>	<4804589A.6040300@reactos.org>
	<00f701c8a329$97af64e0$0201a8c0@zeug>
In-Reply-To: <00f701c8a329$97af64e0$0201a8c0@zeug>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Sebastian Herbszt wrote:
>> I would better name it -display, as not all computers have 
>> VGA-compatible cards.
>
> --- vl.c.orig Tue Apr 15 20:07:18 2008
> +++ vl.c Sun Apr 20 20:47:15 2008
> @@ -7852,6 +7852,7 @@
>     QEMU_OPTION_old_param,
>     QEMU_OPTION_clock,
>     QEMU_OPTION_startdate,
> +    QEMU_OPTION_display,
> };
>
> typedef struct QEMUOption {
> @@ -7964,6 +7965,7 @@
> #endif
>     { "clock", HAS_ARG, QEMU_OPTION_clock },
>     { "startdate", HAS_ARG, QEMU_OPTION_startdate },
> +    { "display", HAS_ARG, QEMU_OPTION_display },
>     { NULL },
> };
>
> @@ -8816,6 +8818,26 @@
>                         }
>                         rtc_date_offset = time(NULL) - rtc_start_date;
>                     }
> +                }
> +                break;
> +            case QEMU_OPTION_display:
> +                if (!strcmp(optarg, "cirrus")) {
> +                    cirrus_vga_enabled = 1;
> +                    vmsvga_enabled = 0;
> +                } else if (!strcmp(optarg, "std")) {
> +                    cirrus_vga_enabled = 0;
> +                    vmsvga_enabled = 0;
> +                } else if (!strcmp(optarg, "vmware")) {
> +                    cirrus_vga_enabled = 0;
> +                    vmsvga_enabled = 1;
> +                } else if (!strcmp(optarg, "none")) {
> +                    serial_devices[0] = "stdio";
> +                    parallel_devices[0] = "null";
> +                    monitor_device = "stdio";
> +                    nographic = 1;

I don't think -display none should be a synonym for -nographic.  It 
should just suppress the creation of a VGA device.  If a platform 
doesn't support that, it should raise an error.

Regards,

Anthony Liguori

> +                } else {
> +                    fprintf(stderr, "Display devices available: 
> cirrus, std, vmware, none\n");
> +                    exit(1);
>                 }
>                 break;
>             }
>
>
> - Sebastian
>
>
>