From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Jnugu-00008j-Lo
	for qemu-devel@nongnu.org; Mon, 21 Apr 2008 08:00:12 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Jnugl-00005c-MS
	for qemu-devel@nongnu.org; Mon, 21 Apr 2008 08:00:10 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Jnugl-00005R-GH
	for qemu-devel@nongnu.org; Mon, 21 Apr 2008 08:00:03 -0400
Received: from ns.suse.de ([195.135.220.2] helo=mx1.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <kwolf@suse.de>) id 1Jnugi-0007Gm-T1
	for qemu-devel@nongnu.org; Mon, 21 Apr 2008 08:00:03 -0400
Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.suse.de (Postfix) with ESMTP id 10A3B4077A
	for <qemu-devel@nongnu.org>; Mon, 21 Apr 2008 13:58:45 +0200 (CEST)
Message-ID: <480C803D.7050100@suse.de>
Date: Mon, 21 Apr 2008 13:53:33 +0200
From: Kevin Wolf <kwolf@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] x86: Reboot CPU on triple fault - Version 6
References: <47EE86E0.4070703@reactos.org>	<9C7667CB-2CF0-4AC0-843B-6EF442196CAC@csgraf.de>	<47F0B445.4030806@suse.de>	<4804D254.5040301@siemens.com>	<4805F4B0.5020802@siemens.com>	<4806009E.8060407@suse.de>	<48060ACC.2020309@siemens.com>	<48060E28.7000606@suse.de>	<480613D3.3080509@suse.de>
	<4808AAD3.5080405@codemonkey.ws>
In-Reply-To: <4808AAD3.5080405@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Anthony Liguori schrieb:
>>   Index: dyngen-exec.h
>> ===================================================================
>> --- dyngen-exec.h    (Revision 4215)
>> +++ dyngen-exec.h    (Arbeitskopie)
>> @@ -86,6 +86,7 @@
>>  extern int fprintf(FILE *, const char *, ...);
>>  extern int fputs(const char *, FILE *);
>>  extern int printf(const char *, ...);
>> +extern FILE *stderr;
>>   
> 
> This is unnecessary.

Right. I'll fix this with the next version.

>> +
>> +        qemu_system_reset_request();
>>   
> 
> This isn't the right function to use here.  If we supported ACPI
> shutdown, this would generate an ACPI shutdown request.  You probably
> want to just do:
> 
> cpu_interrupt(env, CPU_INTERRUPT_EXIT);

Your suggestion doesn't work for me either. qemu keeps hanging producing
lots of triple faults, but there is no CPU reset. Is there even a
function to correctly request a CPU reset only? Directly calling
cpu_reset doesn't work here.

Kevin