From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JpCS3-0001F0-BY for qemu-devel@nongnu.org; Thu, 24 Apr 2008 21:10:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JpCS1-0001Dc-Je for qemu-devel@nongnu.org; Thu, 24 Apr 2008 21:10:10 -0400 Received: from [199.232.76.173] (port=40346 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JpCS1-0001DN-7Z for qemu-devel@nongnu.org; Thu, 24 Apr 2008 21:10:09 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JpCS0-0001cl-M0 for qemu-devel@nongnu.org; Thu, 24 Apr 2008 21:10:08 -0400 Received: from smtp06.web.de (fmsmtp06.dlan.cinetic.de [172.20.5.172]) by fmmailgate03.web.de (Postfix) with ESMTP id F2D3BD865106 for ; Fri, 25 Apr 2008 03:10:07 +0200 (CEST) Received: from [88.65.242.3] (helo=[192.168.1.198]) by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1JpCRz-0007V4-00 for qemu-devel@nongnu.org; Fri, 25 Apr 2008 03:10:07 +0200 Message-ID: <48112F6F.3010202@web.de> Date: Fri, 25 Apr 2008 03:10:07 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [4249] Improve audio api use in WM8750. References: <4810FBF9.1040308@web.de> <48111E61.9050002@web.de> <4811213C.7020507@web.de> <48112992.2000602@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig52494431DC132E10A8412EF0" Sender: jan.kiszka@web.de Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig52494431DC132E10A8412EF0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable andrzej zaborowski wrote: > On 25/04/2008, Jan Kiszka wrote: >> > The checking of whether the guest filled enough data happens in >> > wm8750_dac_dat(), I don't see why do it second time here. The only= >> > place we need an additional check is before s->dat_req call, which = you >> > remove. >> >> True, that's redundant, let's fix it this way (this even obsoletes the= >> flush in out_cb): >=20 > Ok, although I insist that it doesn't obsolete the check in out_cb > (hence why I added it). Imagine s->req_out was 5000, and the guest > already wrote 1000 bytes. Now suddenly audio API calls out_cb with > free_b =3D=3D 1500. In this case we have half of the buffer ready to > write, *before* we call s->data_req. Yes, buffer/2 was attacking the symptom, wrongly, see my other mail. > BTW I just committed a change to the MusicPal LCD, please check if it > still works. Thanks. Still fine! Jan --------------enig52494431DC132E10A8412EF0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFIES9vniDOoMHTA+kRAkjGAJ0Rnd/1CLTrFtMt5f4uqdXd+//WwACfX9OT 4vuiu9Lz+VduOj0Kvt5i/ko= =77ZG -----END PGP SIGNATURE----- --------------enig52494431DC132E10A8412EF0--