From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jpr59-00046Y-MY for qemu-devel@nongnu.org; Sat, 26 Apr 2008 16:33:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jpr58-000452-2y for qemu-devel@nongnu.org; Sat, 26 Apr 2008 16:33:15 -0400 Received: from [199.232.76.173] (port=54435 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jpr57-00044x-SI for qemu-devel@nongnu.org; Sat, 26 Apr 2008 16:33:13 -0400 Received: from hs-out-0708.google.com ([64.233.178.251]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jpr57-0007Iz-H5 for qemu-devel@nongnu.org; Sat, 26 Apr 2008 16:33:13 -0400 Received: by hs-out-0708.google.com with SMTP id k27so2860592hsc.2 for ; Sat, 26 Apr 2008 13:33:12 -0700 (PDT) Message-ID: <48139185.6090206@codemonkey.ws> Date: Sat, 26 Apr 2008 15:33:09 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [4261] Errors while registering ioports are not fatal (Glauber Costa). References: <200804262026.06396.paul@codesourcery.com> <4813844C.7070308@codemonkey.ws> <200804262057.51230.paul@codesourcery.com> In-Reply-To: <200804262057.51230.paul@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org Paul Brook wrote: > On Saturday 26 April 2008, Anthony Liguori wrote: > >> Paul Brook wrote: >> >>> On Saturday 26 April 2008, Andrzej Zaborowski wrote: >>> >>>> Revision: 4261 >>>> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4261 >>>> Author: balrog >>>> Date: 2008-04-26 16:04:29 +0000 (Sat, 26 Apr 2008) >>>> >>>> Log Message: >>>> ----------- >>>> Errors while registering ioports are not fatal (Glauber Costa). >>>> >>> Why shouldn't they be fatal? How can this be anything other than a >>> serious bug in the device emulation? >>> >> I think the idea is that the device should fail to initialize rather the >> VM being destroyed. Consider the case of PCI hotplug. It's a >> recoverable error if register ioport fails during hot add. >> > > The errors that get suppressed aren't the sort of thing that should ever > happen. How exactly do you end up with an IO port that is not 1, 2 or 4 bytes > in size? If this ever happens I want qemu do die right there and then. This > isn't just a failure, it is an indication that something is broken beyond > hope. > The intended error to be suppressed was registering an ioport range that is already registered by something else. Regards, Anthony Liguori > Paul >